WIP Jwt app startup #1467
Closed
WIP Jwt app startup #1467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add text fields and buttons for testing * remove app clips
* Make OSUserJwtConfig object to handle auth status etc * User manager owns an instance of the JWT Config
* User request instances already have a `prepareForExecution()` method that indicates if this request can be sent yet. For example, does the onesignal ID exist to make this request. * Add additional helpers to work with auth status / JWT
Definitely WIP everything is WIp
* User request instances already have a `prepareForExecution()` method that indicates if this request can be sent yet. For example, does the onesignal ID exist to make this request. * Use this existing method to check for auth and block sending this request if auth is required but invalid, or auth is unknown, etc. * Remove any call to `prepareForExecution()` within `init` in order to set the path, this is unnecessary * OSRequestCreateUser * OSRequestAddAliases * OSRequestFetchUser * OSRequestFetchIdentityBySubscription * OSRequestCreateSubscription * OSRequestDeleteSubscription
nan-li
commented
Aug 5, 2024
| @@ -148,7 +148,7 @@ public class OneSignalUserManagerImpl: NSObject, OneSignalUserManager { | |||
| propertiesModel: OSPropertiesModel(changeNotifier: OSEventProducer()), | |||
| pushSubscriptionModel: OSSubscriptionModel(type: .push, address: nil, subscriptionId: nil, reachable: false, isDisabled: true, changeNotifier: OSEventProducer())) | |||
|
|
|||
| @objc public var requiresUserAuth = false | |||
| var jwtConfig = OSUserJwtConfig() | |||
There was a problem hiding this comment.
inject into init of user manager for testing mock, DI pattern
|
Closing for update PR #1473 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super WIP 100% WIP does not run
Description
One Line Summary
REQUIRED - Very short description that summaries the changes in this PR.
Details
Motivation
REQUIRED - Why is this code change being made? Or what is the goal of this PR? Examples: Fixes a specific bug, provides additional logging to debug future issues, feature to allow X.
Scope
RECOMMEND - OPTIONAL - What is intended to be effected. What is known not to change. Example: Notifications are grouped when parameter X is set, not enabled by default.
OPTIONAL - Other
OPTIONAL - Feel free to add any other sections or sub-sections that can explain your PR better.
Testing
Unit testing
OPTIONAL - Explain unit tests added, if not clear in the code.
Manual testing
RECOMMEND - OPTIONAL - Explain what scenarios were tested and the environment.
Example: Tested opening a notification while the app was foregrounded, app build with Android Studio 2020.3 with a fresh install of the OneSignal example app on a Pixel 6 with Android 12.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is