-
-
Notifications
You must be signed in to change notification settings - Fork 72
Ajay: Fixed dark mode for weekly summaries filter modals and selects #4713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Anusha-Gali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vikas-8055
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rohanrastogi311
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shravan-neelamsetty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c40180a
Anusha-Gali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ajay,
Thanks for making the necessary update. That issue appears to be fixed but i found one other issue
Fixed

Trying select filter or Manage filter choice as you can see below the toggle when selected is grey whereas if i select the save option in Select Team Code - it is blue


Note: Do let me know if this is not in your scope since every other requirements works as expected.
rohanrastogi311
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ganesh112001
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested PR #4713 and verified that the dark mode fix for Weekly Summaries filter modals works perfectly. After checking out the Ajay-darkmode-weekly-summaries branch and navigating to /weeklysummariesreport, I enabled dark mode and clicked the "Select Filter" button to open the filter modal. All components in the modal are properly styled for dark mode with good contrast and readability. Input fields, dropdown selects for team codes and extra members, logged hours range selector, and date range filters all have appropriate dark backgrounds with light-colored text. The close button is clearly visible, and there are no white backgrounds breaking the dark theme. Theme toggle works correctly between light and dark modes. No console errors observed. Everything functions perfectly and is ready for merge!
sayali-2308
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing Environment:
- Branch: Ajay-darkmode-weekly-summaries
- Tested as: Admin user
- Browser: Chrome
- Date: January 29, 2026
What Was Tested:
-
Page Navigation:
- Navigated to Reports → Weekly Summaries Report
- Page loaded correctly in both light and dark modes
-
Dark Mode Input Fields:
- "Select Team Code" dropdown - dark styling correct
- "Select Color" dropdown - dark styling correct
- "Select Extra Members" dropdown - dark styling correct
- "Logged Hours Range" dropdown - dark styling correct
- All input fields have proper dark background and readable text
-
Dark Mode UI Components:
- Week selection tabs (This Week, Last Week, etc.) - proper styling
- Toggle switches (Show Chart, Filter by Special Colors, etc.) - work correctly
- Buttons (Select Filter, Manage Filters, Open PDF, Load Badges, etc.) - all functional
- Filter toggles (Purple, Green, Navy, Bio Status, Trophies, Over Hours) - proper styling
-
Dark Mode Modals:
- "Select a Filter" modal - dark background, good contrast
- "Update or Delete Filter" modal - dark background, good contrast
- Modal input fields properly styled
-
Data Display:
- Weekly summary data displays correctly in dark mode
- User information section (blue background) maintains readability
- Text contrast good throughout
-
Cross-Mode Testing:
- Switched between light and dark modes multiple times
- All elements maintain proper styling in both modes
- No visual inconsistencies
Dark mode implementation is complete and functional for all components on the Weekly Summaries Report page. All input fields, dropdowns, modals, and UI elements display correctly with good contrast and readability.
Anusha-Gali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the PR since the issue i have pointed out is not in the scope of the PR and the rest of the functionalities work as per requirements mentioned.
802a96f
sayali-2308
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-reviewed and tested the dark mode implementation for Weekly Summaries Report (#4713).
- Branch:
Ajay-darkmode-weekly-summaries - Backend:
developmentbranch - Tested on: Windows, Chrome
- Date: January 31, 2026
Dark Mode Implementation Verified:
- All input fields properly styled with dark backgrounds and light text:
- "Search and select team codes..." dropdown
- "Select color filters..." dropdown
- "Select extra members..." dropdown
- "Select range..." (Logged Hours Range) dropdown
- All modals display correctly in dark mode:
- "Select a Filter" modal - dark background, good contrast
- Filter details modal - all sections properly styled
- All UI components work correctly:
- Week selection tabs styled properly
- Toggle switches visible and functional
- Buttons (Select Filter, Manage Filters, Open PDF, Load Badges, Load Trophies, Refresh) all have appropriate dark styling
- Dropdown lists properly styled with dark backgrounds
- Data display area maintains good readability with dark blue background
- Text contrast excellent throughout
Minor Observation:
Selected items in dropdown lists show light gray background. While functional, using blue highlighting (like the filter dropdown border) would provide more visual consistency. This is outside the PR scope but worth noting for future enhancement.
rohanrastogi311
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|

























Description
Fixed the dark theme for input fields and all components in Weekly Summaries Report Page.
Related PRS (if any):
Not related to any PR
How to test:
Screenshots or videos of changes:
Recording.2026-01-14.195133.mp4