Skip to content

Conversation

@uhakruthi1
Copy link
Contributor

@uhakruthi1 uhakruthi1 commented Nov 22, 2025

this PR has been redone as #4700

Frontend – SMS Notification Preferences

Screenshot 2025-11-22 at 11 07 49 PM

This PR adds the frontend UI for managing SMS notification preferences.

Related Prs:
Related PRs : PR1366, PR3476, PR#3311 , PR#1289

Features Added
• Toggle to opt in/out of SMS notifications
• Input field to add or update phone number for SMS alerts
• Validation for invalid or empty phone numbers

How to Test
1. Checkout this branch
2. npm install
3. npm start

Expected

✔ Phone number updates correctly
✔ Opt-in/out works
✔ Validation errors show properly
✔ Notification badge updates
✔ No UI crashes


If anyone have doubt running this, ping me on slack

screenshots :
Screenshot 2025-11-22 at 5 13 04 PM
Screenshot 2025-11-22 at 5 13 13 PM
Screenshot 2025-11-22 at 5 13 26 PM

@sonarqubecloud
Copy link

@one-community one-community changed the title fix/ SMS opt-in UI and user preferences - Uha Uha - fix/ SMS opt-in UI and user preferences - Uha Nov 23, 2025
@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Nov 23, 2025
@uhakruthi1 uhakruthi1 changed the title Uha - fix/ SMS opt-in UI and user preferences - Uha Uha - fix/ SMS opt-in UI and user preferences Nov 23, 2025
Copy link

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error in test cases. Additionally, input the full "how to run" (can copy and paste from previous PR if need be).

PR 4438 Screenshot

Copy link

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Uha,

I tried to review your PR locally but i supposed the upstream changes and stashed changes are pushed into the code. I did try editing it but was unable to successfully do so.
Screenshot 2026-01-06 at 6 55 26 PM
Screenshot 2026-01-06 at 6 55 29 PM
Screenshot 2026-01-06 at 6 55 41 PM
Screenshot 2026-01-06 at 6 55 47 PM
Screenshot 2026-01-06 at 6 55 58 PM
Screenshot 2026-01-06 at 6 56 03 PM
Screenshot 2026-01-06 at 6 56 16 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants