Sundar 🔥 empty response from leaderboard data api#2049
Merged
one-community merged 1 commit intodevelopmentfrom Feb 17, 2026
Merged
Sundar 🔥 empty response from leaderboard data api#2049one-community merged 1 commit intodevelopmentfrom
one-community merged 1 commit intodevelopmentfrom
Conversation
one-community
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a production issue where the Dashboard Leaderboard was displaying only the logged-in user instead of all eligible members.
The root cause was a runtime error in getLeaderboard() due to unsafe access of weeklySummaries[0].summary when weeklySummaries was empty or contained null values. This caused the function to throw internally, and because the error was being returned instead of thrown, the controller silently fell back to getUserLaborData(), which returns only the requesting user.
This fix ensures:
• Null-safe access of weeklySummaries
• Proper error propagation (no silent fallback)
• Consistent leaderboard behavior across dev and production environments
Related PRS (if any):
NA
Main changes explained:
Improved old code with better error handling and null checks.
How to test:
npm installand...to run this PR locallyNote:
None