Upgrade to svelte 4 #88
Conversation
Removed Sveltekit entirely as this is just a component library which (hopefully) can be used with both Svelte 3 and 4. Have Sveltekit as a dependency raised peer dependency conflicts as Sveltekit 2 is not compatible with Svelte 3 and Sveltekit 1 is not compatible with Svelte 4. Also updated a couple of other package versions to resolve other peer dependency conflicts that arose from updating the main package versions.
| @@ -18,23 +18,19 @@ | |||
| }, | |||
| "homepage": "https://github.com/Oli8/spaper#readme", | |||
| "scripts": { | |||
| "dev": "svelte-kit dev", | |||
There was a problem hiding this comment.
I think they're replaced with vite commands in newer versions of SvelteKit (e.g. vite dev).
But my suggestion was to remove SvelteKit entirely. I explain more in the PR description but if you remove it then you can have this as a lib that supports both Svelte 3 and 4 as a peer dependency. If you have SvelteKit as a dependency it'll only be able to support one or the other due to dependency conflicts.
|
Might be better/safer if I first upgrade sveltekit |
Just out of interest why do you need SvelteKit? It's just a Svelte component library right? So it may be used without SvelteKit or with another framework. |
Sveltekit provides a great way to write svelte library Also note that currently the package.json of the repo is different from he final package.json of the packaged library, this changes in newer sveltekit version |
|
Although it's on the SvelteKit website it looks like it's just
@sveltejs/package you need not @sveltejs/kit 🙂
…On Wed, 13 Mar 2024, 13:11 Olivier, ***@***.***> wrote:
Might be better/safer if I first upgrade sveltekit
Just out of interest why do you need SvelteKit? It's just a Svelte
component library right? So it may be used without SvelteKit or with
another framework.
Sveltekit provides a great way to write svelte library
https://kit.svelte.dev/docs/packaging
—
Reply to this email directly, view it on GitHub
<#88 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADT4RV445VACY7R6OYPCSD3YYBGAZAVCNFSM6AAAAABEMV67Y2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJUGM3TIOBRHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Looks that way now but it was part of kit then |
Raised a PR with the changes from running
npx svelte-migrate@latest svelte-4plus a couple of my own in package JSON (see commit messages for rationale on those).I've no idea if this has broken anything but judging by the diff it looks very unlikely and this at least creates a branch to test - any suggestions on the best way to do this?
Obviously totally understand if this is not a priority but thought I could at least be as helpful as possible to try get this support in. If merged this would close #87.