Update graphiql to 0.11.11 #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main thing I want from this update is rendering field description as markdown graphql/graphiql@6398718, but I imagine there's other stuff in the update that might be nice or on the other hand might be breaking. Thought I'd put this in to see if you were open to the update, happy to do any other work needed to get this through. I didn't commit the changes from the build script since I figured that might be part of your release process.
mmrobins
added a commit
to mmrobins/absinthe_plug
that referenced
this pull request
Apr 10, 2018
graphql/graphiql@6398718 fixed rendering field descriptions with markdown. To get this update graphiql-workspace needs to update their version of grqphiql OlegIlyenko/graphiql-workspace#37 Then this repo will need to update graphiql-workspace For now I've forked graphiql-workspace so I could try out the update :-/ https://github.com/mmrobins/graphiql-workspace/tree/update_graphiql_fork But it seems to work :-)
Author
|
FWIW I ran the build script locally and am using the output with one of my local projects through https://github.com/absinthe-graphql/absinthe_plug and it seems to work great. |
mmrobins
added a commit
to mmrobins/absinthe_plug
that referenced
this pull request
Dec 3, 2018
graphql/graphiql@6398718 fixed rendering field descriptions with markdown. To get this update graphiql-workspace needs to update their version of grqphiql OlegIlyenko/graphiql-workspace#37 Then this repo will need to update graphiql-workspace For now I've forked graphiql-workspace so I could try out the update :-/ https://github.com/mmrobins/graphiql-workspace/tree/update_graphiql_fork But it seems to work :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main thing I want from this update is rendering field description as
markdown
graphql/graphiql@6398718,
but I imagine there's other stuff in the update that might be nice or on
the other hand might be breaking. Thought I'd put this in to see if you
were open to the update, happy to do any other work needed to get this
through. I didn't commit the changes from the build script since I
figured that might be part of your release process.