Testing functions #11
Conversation
Olamarx
commented
Jun 8, 2022
Olamarx
commented
- Added the delete test function
- Added the add test function
- Explored the mock style
There was a problem hiding this comment.
status: APPROVED 🟢 💯
Hi, @Olamarx and @Zeraltz
Good job so far 👍 Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights ⚡
✅ Descriptive PR 👍
✅ Nice design 🔥
✅ Linters are passing 👏
✅ Tests are passing 👏
Optional suggestions
Check the comment under the reviews
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| let library; | ||
| if (!library) { | ||
| library = []; | ||
| } else { | ||
| library = JSON.parse(localStorage.getItem('library')); | ||
| } | ||
| const content = { | ||
| completed: false, | ||
| task: 'words', | ||
| index: 1, | ||
| }; |
There was a problem hiding this comment.
[OPTIONAL]
- Great job with the test. I think your codebase isn't dry and you're repeating yourself, since you're using the same content and pushing it into the array, you could actually move these blocks of code immediately after the describe block so you could re-use them in each test...
| let library; | ||
| if (!library) { | ||
| library = []; | ||
| } else { | ||
| library = JSON.parse(localStorage.getItem('library')); | ||
| } | ||
| const content = { | ||
| completed: false, | ||
| task: 'kvnodfl', | ||
| index: 1, | ||
| }; |
There was a problem hiding this comment.
- As mentioned above, the same thing is applicable here.
