Skip to content

Conversation

@Fibonacci747
Copy link
Contributor

The slot parameter in blobCacheEntry.filter was unused and redundant. All slot/epoch-sensitive checks happen before filter (commitmentsToCheck), and disk availability is handled via BlobStorageSummary (epoch-aware).

Changes:

  • Drop slot from blobCacheEntry.filter signature.
  • Update call sites in availability_blobs.go and blob_cache_test.go.

Mirrors the data_column_cache.filter API (which does not take slot), reduces API noise, and removes dead code without changing behavior.

@CLAassistant
Copy link

CLAassistant commented Nov 14, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. thanks!

@prestonvanloon prestonvanloon added this pull request to the merge queue Nov 26, 2025
Merged via the queue into OffchainLabs:develop with commit 08d0f42 Nov 26, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants