prevent eas from going backward when increasing cgc #15966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalepae
reviewed
Nov 17, 2025
| } | ||
|
|
||
| // When increasing custody group count, prevent earliestAvailableSlot from going backward. | ||
| if storedEarliestAvailableSlot != 0 && earliestAvailableSlot < storedEarliestAvailableSlot { |
nalepae
reviewed
Nov 17, 2025
| // When increasing custody group count, prevent earliestAvailableSlot from going backward. | ||
| if storedEarliestAvailableSlot != 0 && earliestAvailableSlot < storedEarliestAvailableSlot { | ||
| return errors.Errorf( | ||
| "cannot decrease earliest available slot from %d to %d when increasing custody group count from %d to %d. ", |
Contributor
There was a problem hiding this comment.
No need to add a period at the end of the error.
nalepae
reviewed
Nov 17, 2025
Contributor
nalepae
left a comment
nalepae
left a comment
There was a problem hiding this comment.
I don't see how this PR solves the initial issue.
For sure, if such a thing happens, it will now error.
But the bug will still happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
#15938
Other notes for review
Currently in the process of reproducing the issue locally (kurtosis or otherwise). Only after that we can be sure if the fix in this PR actually fixes this issue.
Edit: I am yet to reproduce but the change in this PR should be there anyway even if it doesn't solve the bug.
Acknowledgements