-
Notifications
You must be signed in to change notification settings - Fork 84
feat: updating setup script to use orbit sdk #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
scripts/transferOwnership.ts
Outdated
l3Provider: ethers.providers.JsonRpcProvider, | ||
childChainRpc: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think l3Provider
includes the RPC URL in the object, can you verify? In that case we wouldn't need the last parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No JsonRpcProvider doesn't have any method to get rpc url which is weird haha
https://docs.ethers.org/v5/api/providers/jsonrpc-provider/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can get it from l3Provider.connection.url
. Just did a quick test, but verify on your end 🙏
The script works and files are much cleaner now, thanks @GreatSoshiant ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much @GreatSoshiant !
There's one minor comment pending, but this LGTM 🚀
Closes: INT-136