arbitrum, common, eth, internal: Implement SendExpressLaneTransactionSync #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolbyML
changed the title
KolbyML
force-pushed
the
Implement-SendExpressLaneTransactionSync
branch
from
bac2dd7 to
633936f
Compare
KolbyML
requested review from
diegoximenes,
ganeshvanahalli and
pmikolajczyk41
ganeshvanahalli
requested changes
Nov 26, 2025
ganeshvanahalli
previously approved these changes
Nov 26, 2025
Contributor
ganeshvanahalli
left a comment
ganeshvanahalli
left a comment
There was a problem hiding this comment.
LGTM.
Good stuff!
pmikolajczyk41
requested changes
Nov 27, 2025
KolbyML
force-pushed
the
Implement-SendExpressLaneTransactionSync
branch
from
94cbe8d to
01bc368
Compare
Member
Author
|
@pmikolajczyk41 @ganeshvanahalli ready for another look, let me know what you think d853327 Me and @pmikolajczyk41 discussed 3 different solutions #588 (comment) for context, anyways let me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://linear.app/offchain-labs/issue/NIT-4118/sendexpresslanetransactionsync
Pulled by OffchainLabs/nitro#4074
Questions I have
*TransactionAPIas a returned value ofGetAPIs(apiBackend Backend)the right move?, I think it is the less error prone and simpler then trying to iterate over the api's, but maybe there is a better way to do this.Normally I would change the functions name, since the returned result is different, but I don't want to due to it being in the geth submodule.