Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CloudFormation template and fix script path #8

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

sadamu
Copy link
Collaborator

@sadamu sadamu commented Jul 22, 2024

No description provided.

@sadamu sadamu force-pushed the add_CF_template branch from 894268d to a5bde30 Compare July 22, 2024 06:36
Copy link
Member

@moratori moratori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

少々気になった箇所がありまして、お手数ですがご確認いただければと思います。

cd ./OWND-Project-VCI || exit
yarn
yarn build
yarn link
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

demos下に配置したことにより、他のデモアプリ同様こちらのyarn linkは不要かと思います。デモアプリのpackage.jsonにて、相対パスでownd-vciを指定している為です。

"ownd-vci": "../../../"

yarn build
yarn link
cd /srv/backend || exit
yarn link ownd-vci
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同様に、こちらのyarn link ownd-vciは不要となります。

pwd
fi

cd /srv/common || exit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

現在は、demosディレクトリと同階層にcommonディレクトリは存在しないと思いますため、ご確認をお願いできればと思います。

Copy link
Member

@moratori moratori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moratori moratori merged commit 274f19b into OWND-Project:develop Jul 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants