-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CloudFormation template and fix script path #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
少々気になった箇所がありまして、お手数ですがご確認いただければと思います。
codedeploy/scripts/after_install.sh
Outdated
cd ./OWND-Project-VCI || exit | ||
yarn | ||
yarn build | ||
yarn link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
demos
下に配置したことにより、他のデモアプリ同様こちらのyarn link
は不要かと思います。デモアプリのpackage.jsonにて、相対パスでownd-vci
を指定している為です。
"ownd-vci": "../../../"
codedeploy/scripts/after_install.sh
Outdated
yarn build | ||
yarn link | ||
cd /srv/backend || exit | ||
yarn link ownd-vci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同様に、こちらのyarn link ownd-vci
は不要となります。
codedeploy/scripts/after_install.sh
Outdated
pwd | ||
fi | ||
|
||
cd /srv/common || exit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
現在は、demos
ディレクトリと同階層にcommon
ディレクトリは存在しないと思いますため、ご確認をお願いできればと思います。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.