-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add demo app event certificate manager #7
Add demo app event certificate manager #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1点コメントしました。ご確認ください。
それに付随するのですが、全体的にtunnelto.dev
は固有のサービス名なので、他に変えたほうが良いかと思いました。
process.env.BASIC_AUTH_USERNAME="username" | ||
process.env.BASIC_AUTH_PASSWORD="password" | ||
process.env.OAUTH2_TOKEN_ENDPOINT="https://example.com/oauth2/token" | ||
process.env.CREDENTIAL_ISSUER="https://datasign-vci.tunnelto.dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここにあるdatasign
も削除した方が良いと思います
結論、該当箇所の文字列を
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added a demo app to issue VC related to the event.