Skip to content

kirkstone: chromium: Update to 132.0.6834.83 #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

adalessandro
Copy link
Contributor

@adalessandro adalessandro commented Feb 28, 2025

Backport from master into kirkstone
#867

chromium: Update to 132.0.6834.83

Release notes:
https://chromereleases.googleblog.com/2025/01/stable-channel-update-for-desktop_14.html

Build and patch changes:

Build options:

Added patches:

  • 0013-Revert-Set-Rust-symbol-visibility-to-hidden-when-C-s.patch
  • 0014-pdfium-Fix-missing-PDFiumAPIStringBufferAdapter-temp.patch
  • 0015-Revert-Connect-the-Rust-log-crate-to-the-base-loggin.patch

Updated patches:

  • 0004-Delete-compiler-options-not-available-in-release-ver.patch
  • Rebased remaining patches.

License changes:

Added licenses:

  • third_party/android_deps/libs/com_google_android_gms_play_services_auth_blockstore/LICENSE
  • third_party/android_deps/libs/com_google_android_gms_play_services_fido/LICENSE
  • third_party/android_deps/libs/com_google_android_libraries_identity_googleid_googleid/LICENSE
  • third_party/libtess2/LICENSE
  • third_party/llvm-libc/src/LICENSE.TXT

Removed licenses:

  • third_party/libavifinfo/LICENSE

Updated licenses:

  • third_party/android_deps/libs/com_google_android_gms_play_services_auth/LICENSE
  • third_party/android_deps/libs/com_google_android_gms_play_services_auth_api_phone/LICENSE
  • third_party/android_deps/libs/com_google_android_gms_play_services_auth_base/LICENSE

Test-built (big thanks to @SoumyaWind):

  • chromium-ozone-wayland

    • kirkstone, clang, MACHINE=qemux86-64
  • chromium-x11

    • kirkstone, clang, MACHINE=qemux86-64, qemuarm, qemuarm64, raspberrypi4-64

chromium: Update to 132.0.6834.83

Release notes:
    https://chromereleases.googleblog.com/2025/01/stable-channel-update-for-desktop_14.html

Build and patch changes:
------------------------------

Build options:
  * Disabled `use_system_libdrm` build option, as no longer supported.
  * https://chromium-review.googlesource.com/c/chromium/src/+/5956068

Added patches:
  * 0013-Revert-Set-Rust-symbol-visibility-to-hidden-when-C-s.patch
  * 0014-pdfium-Fix-missing-PDFiumAPIStringBufferAdapter-temp.patch
  * 0015-Revert-Connect-the-Rust-log-crate-to-the-base-loggin.patch

Updated patches:
  * 0004-Delete-compiler-options-not-available-in-release-ver.patch
  * Rebased remaining patches.

License changes:
------------------------------

Added licenses:
  * third_party/android_deps/libs/com_google_android_gms_play_services_auth_blockstore/LICENSE
  * third_party/android_deps/libs/com_google_android_gms_play_services_fido/LICENSE
  * third_party/android_deps/libs/com_google_android_libraries_identity_googleid_googleid/LICENSE
  * third_party/libtess2/LICENSE
  * third_party/llvm-libc/src/LICENSE.TXT

Removed licenses:
  * third_party/libavifinfo/LICENSE

Updated licenses:
  * third_party/android_deps/libs/com_google_android_gms_play_services_auth/LICENSE
  * third_party/android_deps/libs/com_google_android_gms_play_services_auth_api_phone/LICENSE
  * third_party/android_deps/libs/com_google_android_gms_play_services_auth_base/LICENSE

Test-built (big thanks to @SoumyaWind):
------------------------------

* chromium-ozone-wayland
  * master, clang, MACHINE=qemux86-64

* chromium-x11
  * master, clang, MACHINE=qemux86-64, qemuarm, qemuarm64, raspberrypi4-64

Signed-off-by: Ariel D'Alessandro <[email protected]>
@adalessandro adalessandro marked this pull request as draft February 28, 2025 12:59
@adalessandro
Copy link
Contributor Author

@MaxIhlenfeldt @SoumyaWind this is the PR to backport #867 into kirkstone. Keeping the same delta from master branch, let's test and fix any build errors for this specific distro.

@SoumyaWind
Copy link

I have completed testing for below configuration for poky kirkstone (with meta-lts-mixins: kirkstone/rust, meta-clang: kirkstone-clang18) with latest changes. Here are the results:

  1. chromium-x11 on qemux86-64 target: Compiled successfully without any build issues. Verified chromium version using qemux86-64 emulator
  2. chromium-x11 on qemuarm target: Compiled successfully without any build issues. Verified chromium version using qemuarm emulator
  3. chromium-x11 on qemuarm64 target: Compiled successfully without build issues. Verified chromium version using qemuarm64 emulator
  4. chromium-x11 on raspberrypi4-64 target: Compiled successfully without any build issues. Verified chromium version using Raspberry Pi4.
  5. chromium-ozone-wayland on qemux86-64 target: Compiled successfully without any build issues, verified chromium version using qemux86-64 emulator

@adalessandro adalessandro marked this pull request as ready for review March 6, 2025 12:43
@adalessandro
Copy link
Contributor Author

I have completed testing for below configuration for poky kirkstone (with meta-lts-mixins: kirkstone/rust, meta-clang: kirkstone-clang18) with latest changes. Here are the results:

1. **chromium-x11 on qemux86-64 target:** Compiled successfully without any build issues. Verified chromium version using qemux86-64 emulator

2. **chromium-x11 on qemuarm target:** Compiled successfully without any build issues. Verified chromium version using qemuarm emulator

3. **chromium-x11 on qemuarm64 target:** Compiled successfully without build issues. Verified chromium version using qemuarm64 emulator

4. **chromium-x11 on raspberrypi4-64 target:** Compiled successfully without any build issues. Verified chromium version using Raspberry Pi4.

5. **chromium-ozone-wayland on qemux86-64 target:** Compiled successfully without any build issues, verified chromium version using qemux86-64 emulator

Great! I have updated the PR description with your tests.

IIRC, no issues were reported in kirkstone builds while working on #867 either. So we should be ready to merge this.

Copy link
Collaborator

@MaxIhlenfeldt MaxIhlenfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken the liberty to modify the test-built section myself and swap out master for kirkstone.

lgtm, thanks!

@MaxIhlenfeldt MaxIhlenfeldt merged commit 935aabc into OSSystems:kirkstone Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants