Removed superfluous (and erroneous) key type check - #8
Merged
Merged
Conversation
rimi-itk
force-pushed
the
hotfix/remove-key-type-check
branch
from
September 1, 2026 13:35
0f066e5 to
a3682e5
Compare
rimi-itk
marked this pull request as ready for review
September 1, 2026 13:40
jekuaitk
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The HashiCorp Vault key provider checks the key type and only accepts “certificate”. The HashiCorp Vault can contain anything – not just certificates – se this checks is superfluous and actually makes some valid usecases impossible to implement (e.g. getting a private ssh key from the vault).
Therefore, we remove the check for key type.
Additional comments or questions
The failing checks are not related to changes in this pull request.