OutputBlackoilModule: add a container for the FIP data #5939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a container for the FIP map and associated code in OutputBlackoilModule. start by adding allocation functionality. for now the container only owns a reference to the map
|
jenkins build this please |
akva2
force-pushed
the
output_refactor_fip
branch
from
421258e to
01a5641
Compare
|
Okay, this is now ready for review. The code is still somewhat finicky and confusing, but I think this puts us in a better place to do cleanup. |
|
jenkins build this please |
bska
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Greatly appreciated. Packaging those ! empty() calls into a nicer interface is a very welcome change. I do foresee some potential future improvements in this area. We almost always use these values aggregated to at least the region level, and often the field level, so we might not always need to allocate full per-cell storage. As I said, though, that's potential follow-up work so for now I'll merge this into the master branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to clean up this code a little. Still some mysteries I haven't gotten my head around.