Return group/well potentials from GuideRate object #4567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
|
jenkins build this please |
|
jenkins build this please |
|
jenkins build this please |
|
jenkins build this opm-simulators=6170 please |
Add a helper method to return group/well potentials. This is to be used by the reservoir coupling code in opm-simulators.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
jenkins build this opm-simulators=6170 please |
1 similar comment
|
jenkins build this opm-simulators=6170 please |
blattms
reviewed
Apr 16, 2025
Comment on lines
+138
to
+143
| if (!this->hasPotentials(name)) { | ||
| auto message = fmt::format("Potentials for '{}' do not exist.", name); | ||
| throw std::logic_error {message}; | ||
| } | ||
| return this->potentials.at(name); | ||
| } |
There was a problem hiding this comment.
You are triggering two searches here: one in hasPotentials and the other one ins at. In addition there is double error handling as at does another check.
If you want the better error message then we could do:
Suggested change
| if (!this->hasPotentials(name)) { | |
| auto message = fmt::format("Potentials for '{}' do not exist.", name); | |
| throw std::logic_error {message}; | |
| } | |
| return this->potentials.at(name); | |
| } | |
| if (const auto candidate = this->potentials.find(name); candidate == this->potentials.end()) { | |
| auto message = fmt::format("Potentials for '{}' do not exist.", name); | |
| throw std::logic_error {message}; | |
| } else { | |
| return candidate->second; | |
| } | |
| } |
blattms
requested changes
Apr 16, 2025
There was a problem hiding this comment.
The failing test mpi.compareECLFiles_flow+MOD4_UDQ_ACTIONX is strange.
At least this PR seems innocent.
|
jenkins build this opm-simulators=6170 serial please |
|
It seems like compilation in serial is broken for the opm-simulator part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a helper method to return group/well potentials. This is to be used by the reservoir coupling code in opm-simulators, see OPM/opm-simulators#6170