xtest: pkcs11: Add all attributes for RSA AES Key Wrap/Unwrap #790
Conversation
Modified test 1019 to use digest_test_pattern_sha512 instead of digest_test_pattern_sha256.
This change adds all the attributes for RSA AES Keypair Generation
|
Hi @etienne-lms |
| { CKA_EXPONENT_2, (CK_VOID_PTR)t->key.exp2, | ||
| t->key.prime2_len }, | ||
| { CKA_COEFFICIENT, (CK_VOID_PTR)t->key.coeff, | ||
| t->key.coeff_len }, |
There was a problem hiding this comment.
This info used here (t->key.*) belong to the wrapping key, not the to target wrapped/unwrapped key which target_key_template relates to.
| { CKA_EXPONENT_2, (CK_VOID_PTR)t->key.exp2, | ||
| t->key.prime2_len }, | ||
| { CKA_COEFFICIENT, (CK_VOID_PTR)t->key.coeff, | ||
| t->key.coeff_len }, |
There was a problem hiding this comment.
These attributes relate the private keys whereas wrapping_key_template defines a public key.
| { CKA_EXPONENT_2, (CK_VOID_PTR)t->key.exp2, | ||
| t->key.prime2_len }, | ||
| { CKA_COEFFICIENT, (CK_VOID_PTR)t->key.coeff, | ||
| t->key.coeff_len }, |
There was a problem hiding this comment.
I don't think this information are needed. They can be recomputed by the pkcs11 token based on the provided CKA_PRIVATE_EXPONENT, CKA_PRIME_1 and CKA_PRIME_2 attributes.
|
Commenting it so that issue is not marked stale |
1 similar comment
|
Commenting it so that issue is not marked stale |
|
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time. |
|
Keeping it alive |
|
Keeping it alive |
This change adds all the attributes for RSA AES Keypair Generation.