Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtest: remove CFG_SECSTOR_TA_MGMT_PTA dependency #768

Merged
merged 1 commit into from
Jan 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions Android.mk
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ srcs += adbg/src/adbg_case.c \
regression_8000.c \
regression_8100.c \
hash_perf.c \
install_ta.c \
stats.c \
symm_cipher_perf.c \
xtest_helpers.c \
Expand All @@ -64,10 +65,6 @@ ifeq ($(CFG_SECURE_PARTITION)-$(CFG_SPMC_TESTS),y-y)
srcs += ffa_spmc_1000.c
endif

ifeq ($(CFG_SECSTOR_TA_MGMT_PTA),y)
srcs += install_ta.c
endif

ifeq ($(CFG_SECURE_DATA_PATH),y)
srcs += sdp_basic.c
endif
Expand Down
5 changes: 1 addition & 4 deletions host/xtest/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ set (SRC
regression_8000.c
regression_8100.c
hash_perf.c
install_ta.c
stats.c
symm_cipher_perf.c
xtest_helpers.c
Expand Down Expand Up @@ -101,10 +102,6 @@ if (CFG_GP_SOCKETS)
)
endif()

if (CFG_SECSTOR_TA_MGMT_PTA)
list (APPEND SRC install_ta.c)
endif()

if (CFG_SECURE_DATA_PATH)
list (APPEND SRC sdp_basic.c)
endif()
Expand Down
5 changes: 1 addition & 4 deletions host/xtest/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ srcs += adbg/src/adbg_case.c \
regression_8000.c \
regression_8100.c \
hash_perf.c \
install_ta.c \
stats.c \
symm_cipher_perf.c \
xtest_helpers.c \
Expand All @@ -83,10 +84,6 @@ ifeq ($(CFG_SECURE_PARTITION)-$(CFG_SPMC_TESTS),y-y)
srcs += ffa_spmc_1000.c
endif

ifeq ($(CFG_SECSTOR_TA_MGMT_PTA),y)
srcs += install_ta.c
endif

ifeq ($(CFG_SECURE_DATA_PATH),y)
srcs += sdp_basic.c
endif
Expand Down
2 changes: 2 additions & 0 deletions host/xtest/install_ta.c
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,8 @@ int install_ta_runner_cmd_parser(int argc, char *argv[])

res = TEEC_OpenSession(&ctx, &sess, &uuid, TEEC_LOGIN_PUBLIC, NULL,
NULL, &err_origin);
if (res == TEEC_ERROR_ITEM_NOT_FOUND && err_origin == TEEC_ORIGIN_TEE)
errx(1, "TA install is not supported by OP-TEE");
if (res)
errx(1, "TEEC_OpenSession: res %#" PRIx32 " err_orig %#" PRIx32,
res, err_origin);
Expand Down
4 changes: 0 additions & 4 deletions host/xtest/xtest_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,8 @@ void usage(char *program)
printf("\t--hash-perf [opts] Hash performance testing tool (-h for usage)\n");
printf("\t--aes-perf [opts] AES performance testing tool (-h for usage)\n");
printf("\t--asym-perf [opts] Asym performance testing tool (-h for usage)\n");
#ifdef CFG_SECSTOR_TA_MGMT_PTA
printf("\t--install-ta [directory or list of TAs]\n");
printf("\t Install TAs\n");
#endif
#ifdef CFG_SECURE_DATA_PATH
printf("\t--sdp-basic [opts] Basic Secure Data Path test setup ('-h' for usage)\n");
#endif
Expand Down Expand Up @@ -172,10 +170,8 @@ int main(int argc, char *argv[])
return aes_perf_runner_cmd_parser(argc-1, &argv[1]);
else if (argc > 1 && !strcmp(argv[1], "--asym-perf"))
return asym_perf_runner_cmd_parser(argc-1, &argv[1]);
#ifdef CFG_SECSTOR_TA_MGMT_PTA
else if (argc > 1 && !strcmp(argv[1], "--install-ta"))
return install_ta_runner_cmd_parser(argc - 1, argv + 1);
#endif
#ifdef CFG_SECURE_DATA_PATH
else if (argc > 1 && !strcmp(argv[1], "--sdp-basic"))
return sdp_basic_runner_cmd_parser(argc-1, &argv[1]);
Expand Down
Loading