-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression 1040: test interrupt notification #663
Conversation
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time. |
ret_orig); | ||
if (res == TEEC_ERROR_NOT_SUPPORTED) { | ||
/* Embedding tests is optional: warn and nicely exit */ | ||
Do_ADBG_Log(" - 1040 - skip test, not implemented"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the ADBG_EXPECT_TEEC_ERROR_ORIGIN
call fails, then this doesn't help, or? The test will still end with an error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test calls the Invoke test PTA. Line 3284 already address the case where the PTA is not embedded. Once we know the PTA is embedded, we require the PTA to answer our request, hence the test at line 3294.
Di I miss something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After re-reading the code, I think you're right. My first impression was that this eventually could end up logging an adbg error, while still printing the "skip test".
Acked-by: Joakim Bech <[email protected]>
Adds regression test 1040 to invoke a new Invoke test PTA command that triggers interrupt notification tests. When the command is not supported or Invoke test PTA not embedded, the test is skipped. Acked-by: Joakim Bech <[email protected]> Signed-off-by: Etienne Carriere <[email protected]>
tag applied |
IBART test failure due to dependency on OP-TEE/optee_os#5793. |
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time. |
please keep alive |
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time. |
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time. |
(Respin of #640. Related to optee_os P-R OP-TEE/optee_os#5793 for interrupt notif to non-secure world)
Adds regression test 1040 to invoke a new Invoke test PTA command that triggers interrupt notification tests. When the command is not supported or Invoke test PTA not embedded, the test is skipped.