KEH-2171: Assume Service Role via SSO#19
Conversation
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 4 | 0 | 0 | 0.06s | |
| ✅ ACTION | zizmor | 4 | 0 | 0 | 2.17s | |
| bash-exec | 4 | 2 | 0 | 0.01s | ||
| ✅ BASH | shellcheck | 4 | 0 | 0 | 0.07s | |
| ✅ BASH | shfmt | 4 | 0 | 0 | 0.0s | |
| ✅ DOCKERFILE | hadolint | 1 | 0 | 0 | 0.04s | |
| ✅ REPOSITORY | checkov | yes | no | no | 25.39s | |
| ✅ REPOSITORY | gitleaks | yes | no | no | 5.3s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.01s | |
| ✅ REPOSITORY | grype | yes | no | no | 44.21s | |
| ✅ REPOSITORY | osv-scanner | yes | no | no | 0.46s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 0.85s | |
| ✅ REPOSITORY | syft | yes | no | no | 1.46s | |
| ✅ REPOSITORY | trivy | yes | no | no | 13.53s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.3s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 2.25s | |
| ✅ YAML | prettier | 8 | 0 | 0 | 0.47s | |
| ✅ YAML | v8r | 8 | 0 | 0 | 5.25s | |
| ✅ YAML | yamllint | 8 | 0 | 0 | 0.6s |
Detailed Issues
⚠️ BASH / bash-exec - 2 errors
Results of bash-exec linter (version 5.3.3)
See documentation on https://megalinter.io/9.5.0/descriptors/bash_bash_exec/
-----------------------------------------------
❌ [ERROR] concourse/scripts/assume_role.sh
Error: File:[concourse/scripts/assume_role.sh] is not executable
✅ [SUCCESS] concourse/scripts/build_image.sh
✅ [SUCCESS] concourse/scripts/set_pipeline.sh
❌ [ERROR] concourse/scripts/terraform_infra.sh
Error: File:[concourse/scripts/terraform_infra.sh] is not executable
Notices
📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)
See detailed reports in MegaLinter artifacts
You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:
- oxsecurity/megalinter/flavors/documentation@v9.5.0 (52 linters)
- oxsecurity/megalinter/flavors/ruby@v9.5.0 (53 linters)
- oxsecurity/megalinter/flavors/rust@v9.5.0 (53 linters)
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,ACTION_ZIZMOR,BASH_EXEC,BASH_SHELLCHECK,BASH_SHFMT,DOCKERFILE_HADOLINT,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_OSV_SCANNER,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

Show us your support by starring ⭐ the repository
…book-lambda into KEH-2171-Assume-Service-Role-SSO
co-opsw
left a comment
There was a problem hiding this comment.
Just a small minor but will approve beforehand as it is not anything destructive
| name: MkDocs CI | ||
|
|
||
| on: | ||
| "on": |
There was a problem hiding this comment.
For megalinter this rule should be turned off, should be on DL as a rule :)
| --- | ||
| name: Deploy MkDocs | ||
| on: | ||
| "on": |
What type of PR is this? (check all applicable)
What
The IAM role for this service can now be assumed via SSO for the most secure development experience.
Testing
Have any new tests been added as part of this issue? If not, try to explain why test coverage is not needed here.
Please write a brief description of why test coverage is not necessary here.
Documentation
Has any new documentation been written as part of this issue? We should try to keep documentation up to date
as new code is added, rather than leaving it for the future.
Please write a brief description of why documentation is not necessary here.
Related issues
N/A
How to review
Check that instructions in updated README to run the service make sense. If you wish, you may also follow the updated instructions itself to run the service.