Cryptoms 3.2 redone#445
Open
MGwynne wants to merge 2 commits intoOKullmann:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch: cryptoms-3.2-redone.
Installing cryptominisat-3.2 now completely rewritten from scratch.
There is now no "allcryptominisat", or "cleancryptominisat3" etc - the whole thing is much simpler and more in line with other scripts such as gcc412.
Two things:
(1) cryptominisat3 requires cmake to build. I think we discussed this at some point and agreed that this was on most linux systems by default now. Should this be added to the README?
(2) I haven't added cryptominisat3 to the list of packages to be built with "oklib all" etc. I assumed, for now, that cryptominisat3 is more for testing, not something to be included by default.
I will resend the m4ri and cryptominisat tarballs in an e-mail.
Matthew