Add a test to cover corner cases in add_predicate
#1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Instances` does not handle ground predicates the same way as other predicates. These corner cases are not covered by our non-regression tests (add an assertion if you do not believe me). This PR adds a test in AE format to cover these cases. Note that we cannot cover them with a SMT format test, as we do not differentiate functions and predicates in `Translate` for this format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Instancesmodule does not handle ground predicates the same way as other predicates. These corner cases are not covered by our non-regression tests (add an assertion if you do not believe me).This PR adds a test in AE format to cover these cases.
Note that we cannot cover them with a SMT format test, as we do not differentiate functions and predicates in
Translatefor this format.