Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: don't clean venvs in -git prebuilds #174

Merged
merged 1 commit into from
Aug 21, 2020
Merged

docker: don't clean venvs in -git prebuilds #174

merged 1 commit into from
Aug 21, 2020

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented Aug 21, 2020

Fix #173

This is urgent

@bertsky bertsky requested review from kba and stweil August 21, 2020 08:43
@stweil stweil merged commit df7876d into OCR-D:master Aug 21, 2020
kba
kba reviewed Aug 21, 2020
View reviewed changes
Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was fast. But "approve" for the record :)

@stweil
Copy link
Collaborator

stweil commented Aug 21, 2020

Approved. :-)

@stweil
Copy link
Collaborator

stweil commented Aug 21, 2020

Commit 75e6eb5 should fix CI for builds without ocrd_olena or tesseract.

@bertsky bertsky deleted the fix-docker-build-clean branch August 21, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kba kba kba left review comments

@stweil stweil Awaiting requested review from stweil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker prebuilds: git variants utterly broken
3 participants
@bertsky @stweil @kba