Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] survey_partner_representative: Migration to version 17.0 #145

Merged

Conversation

pilarvargas-tecnativa
Copy link

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 17.0-mig-survey_partner_representative branch from ee38dec to af9aa76 Compare January 27, 2025 11:07
@pedrobaeza
Copy link
Member

/ocabot migration survey_partner_representative

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jan 27, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 27, 2025
4 tasks
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny detail:

survey_partner_representative/controllers/main.py Outdated Show resolved Hide resolved
survey_partner_representative/models/survey_survey.py Outdated Show resolved Hide resolved
survey_partner_representative/models/survey_user_input.py Outdated Show resolved Hide resolved
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, just a minor changes

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 17.0-mig-survey_partner_representative branch from af9aa76 to 1ed5639 Compare January 28, 2025 14:30
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-145-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit edc5938 into OCA:17.0 Jan 28, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a06e33a. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-mig-survey_partner_representative branch January 28, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants