Skip to content

[16.0][ADD]survey_link_base #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2025
Merged

[16.0][ADD]survey_link_base #141

merged 1 commit into from
Jun 14, 2025

Conversation

adasatorres
Copy link

Good morning, this addon creates a mixin and a wizard to enable the generation of surveys from other models.

@adasatorres adasatorres force-pushed the 16.0-add-survey_link_base branch 2 times, most recently from 095eb12 to fda2eac Compare December 30, 2024 15:23
jorgeglez1990
jorgeglez1990 approved these changes Dec 30, 2024
View reviewed changes
Copy link

@jorgeglez1990 jorgeglez1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review: LGTM.

@adasatorres adasatorres force-pushed the 16.0-add-survey_link_base branch 2 times, most recently from 87f002c to e8ed555 Compare December 30, 2024 19:58
@adasatorres adasatorres force-pushed the 16.0-add-survey_link_base branch 3 times, most recently from 8967120 to 2373bad Compare December 31, 2024 07:18
This was referenced Dec 31, 2024
Open
Open
Open
rrebollo
rrebollo approved these changes Jan 3, 2025
View reviewed changes
Copy link

@rrebollo rrebollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review LGTM! Consider my suggestions.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@adasatorres adasatorres force-pushed the 16.0-add-survey_link_base branch from 2373bad to 629105b Compare January 14, 2025 18:29
@diggy128
Copy link

It seems runboat is stuck. Can someone retrigger the build?

@adasatorres adasatorres force-pushed the 16.0-add-survey_link_base branch from 629105b to 1edd0b4 Compare February 21, 2025 12:39
@diggy128
Copy link

Runboat seems stuck again. Can someone retrigger the build?

diggy128
diggy128 suggested changes May 28, 2025
View reviewed changes
@adasatorres adasatorres force-pushed the 16.0-add-survey_link_base branch 2 times, most recently from c1cb2fa to d5f65d3 Compare June 2, 2025 18:23
@adasatorres
Copy link
Author

Hi, @diggy128 thank you for your review.

@adasatorres adasatorres requested a review from diggy128 June 2, 2025 18:31
edescalona
edescalona approved these changes Jun 13, 2025
View reviewed changes
Copy link

@edescalona edescalona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jun 14, 2025
pedrobaeza
pedrobaeza requested changes Jun 14, 2025
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is OK, but it shouldn't include the partner link, at least in regular install (you may do it in demo, but _partner_field Python variable nor the method is not allowing to put this as demo data.

As is, it will choke with partner_survey module.

@adasatorres
Copy link
Author

Should I remove the integration with the partner? @pedrobaeza

@adasatorres adasatorres force-pushed the 16.0-add-survey_link_base branch from d5f65d3 to b58bda1 Compare June 14, 2025 12:04
pedrobaeza
pedrobaeza approved these changes Jun 14, 2025
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-141-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 14, 2025
@OCA-git-bot
Merge PR #141 into 16.0
1f27938 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-141-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@adasatorres
Copy link
Author

Sorry, @pedrobaeza i need refactor the tests.

@adasatorres adasatorres force-pushed the 16.0-add-survey_link_base branch 2 times, most recently from b4883a3 to 8fcc222 Compare June 14, 2025 14:25
dreispt
dreispt reviewed Jun 14, 2025
View reviewed changes
@adasatorres adasatorres force-pushed the 16.0-add-survey_link_base branch from 8fcc222 to 15ef3d6 Compare June 14, 2025 14:47
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-141-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a57011b into OCA:16.0 Jun 14, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 06d767b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreispt dreispt dreispt left review comments

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@rrebollo rrebollo rrebollo approved these changes

@edescalona edescalona edescalona approved these changes

@jorgeglez1990 jorgeglez1990 Awaiting requested review from jorgeglez1990

@diggy128 diggy128 Awaiting requested review from diggy128

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
8 participants
@adasatorres @OCA-git-bot @diggy128 @pedrobaeza @dreispt @rrebollo @edescalona @jorgeglez1990