[15.0][ADD] survey_partner_representative: New module #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems a temporary deb file has slipped into the PR. |
chienandalu
force-pushed
the
15.0-add-survey_partner_representative
branch
from
e0b540a to
27748ce
Compare
|
Oh, weird, maybe it has to do with the new fragments conversion |
chienandalu
force-pushed
the
15.0-add-survey_partner_representative
branch
2 times, most recently
from
e363e02 to
643b579
Compare
pedrobaeza
approved these changes
Jan 11, 2024
Comment on lines
16
to
19
| if self.allow_partner_representing: | ||
| return super( | ||
| SurveySurvey, self.with_context(survey_partner_representative=True) | ||
| )._create_answer(*args, **kwargs) |
There was a problem hiding this comment.
This way is more compact and readable:
Suggested change
| if self.allow_partner_representing: | |
| return super( | |
| SurveySurvey, self.with_context(survey_partner_representative=True) | |
| )._create_answer(*args, **kwargs) | |
| if self.allow_partner_representing: | |
| self = self.with_context(survey_partner_representative=True) |
chienandalu
force-pushed
the
15.0-add-survey_partner_representative
branch
from
643b579 to
7f5d7ae
Compare
pedrobaeza
reviewed
Jan 12, 2024
Do surveys on behalf of others. TT46965
chienandalu
force-pushed
the
15.0-add-survey_partner_representative
branch
from
7f5d7ae to
b2bb903
Compare
pedrobaeza
approved these changes
Jan 12, 2024
victoralmau
approved these changes
Jan 16, 2024
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 91966a6. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have the modules
survey_contact_generation,survey_sale_generationorsurvey_crm_generationa salesman or a portal users could want to act as a representative of another using the surveys that generate those documents as an entry point.Pending:
cc @Tecnativa TT46965
ready for review @pedrobaeza @victoralmau