Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][FIX] survey_resource_booking: adapt to partner refactor #104

Merged

Conversation

chienandalu
Copy link
Member

We need to adapt tests to OCA/calendar#110

cc @Tecnativa TT45338

please review @carolinafernandez-tecnativa @pedrobaeza

@OCA-git-bot
Copy link
Contributor

Hi @yajo,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 15.0 milestone Nov 29, 2023
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast-tracking this as obvious:

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-104-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 64c250e into OCA:15.0 Nov 29, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5b17547. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-fix-survey_resource_booking-refactor branch November 29, 2023 11:12
@chienandalu
Copy link
Member Author

Also failing affecting to the tests in sale_resource_booking and website_sale_resource_booking (investigating...)

@pedrobaeza
Copy link
Member

One way to avoid this compatibility problem is to add an inverse function to partner_id field, so that it put on partner_ids the proper value. Do you know what I mean?

@chienandalu
Copy link
Member Author

Yes, I was thinking about that, although in this case the problem is that using the Form class, the field should be in the view

@pedrobaeza
Copy link
Member

Not sure if putting it as invisible will serve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants