[MIG]Migrate stock_picking_show_return from v11 to v12 #477

bizzappdev · 2018-11-24T10:29:17Z

Migrate from v11 to v12
#457

bodedra

IMHO You have to respect commit history following migration guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-12.0#technical-method-to-migrate-a-module-from-110-to-120-branch

============================== Show returns on stock pickings ============================== This module enables one tab in the pickings that contains returns made for that picking.

The returned picking must be obtained from the picking of the iteration, not the set of pickings to be calculated.

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

For avoiding errors when other modules add required fields on affected models

bizzappdev · 2018-11-25T04:51:52Z

Commit history has been added

bodedra

@bizzappdev Thanks for migration. Would you please correct minor changes. Other than it's LGTM

bodedra · 2018-11-26T05:16:34Z

stock_picking_show_return/README.rst

+
+.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
+   :alt: Try me on Runbot
+   :target: https://runbot.odoo-community.org/runbot/154/11.0


Should be 12.0

You can use README by fragments and generate this automatically: https://github.com/OCA/maintainer-tools/#readme-generator

bodedra · 2018-11-26T05:17:12Z

stock_picking_show_return/__manifest__.py

+    "author": "Tecnativa, "
+              "Odoo Community Association (OCA)",
+    "category": "Warehouse Management",
+    "website": "https://www.tecnativa.com",


Should be https://github.com/OCA/stock-logistics-workflow

bizzappdev · 2018-11-26T06:33:05Z

suggested change are done

bodedra

Code Review 👍

nikul-serpentcs · 2018-12-22T05:49:51Z

@bizzappdev Use new README by fragment system, copying https://github.com/OCA/maintainer-tools/tree/master/template/module/readme and editing or removing the needed sections. You can then run locally oca-gen-addon-readme if you have OCA/maintainer-tools installed and you want to pre-generate the README.rst file (preferred), or keep the previous README.rst file.

Swapnesh-SerpentCS · 2018-12-22T09:52:34Z

stock_picking_show_return/models/stock_picking.py

+class StockPicking(models.Model):
+    _inherit = 'stock.picking'
+
+    returned_ids = fields.Many2many(


We should use table name (Eg. relation='returned_picking_relation') explicitly to prevent sharing same table name (In case one have m2m with same object)
Related PR on Github: odoo/odoo#29376 and odoo/odoo#29323

@Swapnesh-SerpentCS As it is non-store field it will not create any database table

nikul-serpentcs

Improve Code

nikul-serpentcs · 2018-12-24T05:11:18Z

stock_picking_show_return/README.rst

+|badge1| |badge2| |badge3| |badge4| |badge5| 
+
+=================================
+Display returns on stock pickings


@bizzappdev Remove it, Two time added

nikul-serpentcs · 2018-12-24T05:12:10Z

stock_picking_show_return/readme/DESCRIPTION.rst

@@ -0,0 +1,6 @@
+=================================
+Display returns on stock pickings


stock_picking_show_return/tests/test_stock_picking_show_return.py

nikul-serpentcs · 2018-12-24T11:51:24Z

@bizzappdev squash commits

bizzappdev · 2019-01-30T08:37:08Z

squash commits

sorry but I am not good in Squashing. might be the merger will do.

pedrobaeza · 2019-01-30T08:46:09Z

You can see the guide for that: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

Tell me if you have any doubt. This can't be done at merge time unless the merger downloads locally the branch, do the squashing and force push over your PR. If no luck, I'll do it.

nikul-serpentcs · 2019-01-30T09:22:03Z

squash commits

sorry but I am not good in Squashing. might be the merger will do.

@bizzappdev follow this command/steps:
git rebase -i HEAD~6
after open file like this pick c70a0dc ..,
you rename pick to f,
Note: not rename first pick.( this one [MIG]stock_picking_show_return: migration from 11 to v12)
after save file and git push origin branch_name -f

bizzappdev · 2019-01-30T09:54:55Z

thanks @pedrobaeza for pointing doc. I had only doubt that last time when I forced push the PR was automatically closed that is why I was worrying. I have force pushed the commit with squash. Please check
cc @nikul-serpentcs

stock_picking_show_return/README.rst

stock_picking_show_return/__manifest__.py

rousseldenis

Code review. Minor changes

[11.0][NEW] stock_secondary_unit: New module for get stock in a secondary unit

rousseldenis added the needs review label Nov 24, 2018

rousseldenis added this to the 12.0 milestone Nov 24, 2018

OCA-git-bot mentioned this pull request Nov 24, 2018

Migration to version 12.0 #457

Open

34 tasks

bodedra suggested changes Nov 24, 2018

View reviewed changes

pedrobaeza and others added 11 commits November 25, 2018 10:18

[REN] stock_picking_show_returns > stock_picking_show_return

a6e02fb

stock_picking_show_return

3ffd661

============================== Show returns on stock pickings ============================== This module enables one tab in the pickings that contains returns made for that picking.

stock_picking_show_return: Tests

af1a405

stock_picking_show_return: Migrated to 9.0

e27b6db

stock_picking_show_return: Typo

a980ddf

The returned picking must be obtained from the picking of the iteration, not the set of pickings to be calculated.

[MIG] stock_picking_show_return: Migration to 10.0

f5f6527

[IMP] stock_*: Execute tests at the end

97225ce

For avoiding errors when other modules add required fields on affected models

[MIG] Migrated stock_picking_show_return to v11.0

c0c5b07

remove obsolete .pot files [ci skip]

337fa3b

[UPD] Update stock_picking_show_return.pot

44b308c

bizzappdev force-pushed the 12.0-mig-stock_picking_show_return branch from e0d3553 to 4f478fb Compare November 25, 2018 04:51

bodedra suggested changes Nov 26, 2018

View reviewed changes

bodedra approved these changes Nov 26, 2018

View reviewed changes

Swapnesh-SerpentCS reviewed Dec 22, 2018

View reviewed changes

nikul-serpentcs reviewed Dec 24, 2018

View reviewed changes

stock_picking_show_return/tests/test_stock_picking_show_return.py Show resolved Hide resolved

bizzappdev force-pushed the 12.0-mig-stock_picking_show_return branch from 45c6c48 to a41fe7e Compare January 30, 2019 09:51

rousseldenis reviewed Jan 30, 2019

View reviewed changes

stock_picking_show_return/README.rst Outdated Show resolved Hide resolved

rousseldenis reviewed Jan 30, 2019

View reviewed changes

stock_picking_show_return/__manifest__.py Outdated Show resolved Hide resolved

rousseldenis requested changes Jan 30, 2019

View reviewed changes

[MIG]stock_picking_show_return: migration from 11 to v12

4bca2ca

bizzappdev force-pushed the 12.0-mig-stock_picking_show_return branch from a5f759f to 4bca2ca Compare January 30, 2019 13:49

rousseldenis approved these changes Jan 30, 2019

View reviewed changes

OCA-git-bot added the approved label Jan 30, 2019

pedrobaeza merged commit 789a848 into OCA:12.0 Feb 2, 2019

jaredkipe pushed a commit to hibou-io/oca-stock-logistics-workflow that referenced this pull request May 6, 2019

Merge pull request OCA#477 from Tecnativa/11.0-PR-stock_secondary_unit

d84776c

[11.0][NEW] stock_secondary_unit: New module for get stock in a secondary unit

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG]Migrate stock_picking_show_return from v11 to v12 #477

[MIG]Migrate stock_picking_show_return from v11 to v12 #477

bizzappdev commented Nov 24, 2018

bodedra left a comment

bizzappdev commented Nov 25, 2018

bodedra left a comment

bodedra Nov 26, 2018

pedrobaeza Nov 26, 2018

bizzappdev Dec 22, 2018

bodedra Nov 26, 2018

bizzappdev Dec 22, 2018

bizzappdev commented Nov 26, 2018

bodedra left a comment

nikul-serpentcs commented Dec 22, 2018

Swapnesh-SerpentCS Dec 22, 2018

bizzappdev Dec 22, 2018

nikul-serpentcs left a comment

nikul-serpentcs Dec 24, 2018

nikul-serpentcs Dec 24, 2018

bizzappdev Dec 24, 2018 •

edited

Loading

nikul-serpentcs commented Dec 24, 2018

bizzappdev commented Jan 30, 2019

pedrobaeza commented Jan 30, 2019

nikul-serpentcs commented Jan 30, 2019

bizzappdev commented Jan 30, 2019

rousseldenis left a comment

		@@ -0,0 +1,6 @@
		=================================
		Display returns on stock pickings

[MIG]Migrate stock_picking_show_return from v11 to v12 #477

[MIG]Migrate stock_picking_show_return from v11 to v12 #477

Conversation

bizzappdev commented Nov 24, 2018

bodedra left a comment

Choose a reason for hiding this comment

bizzappdev commented Nov 25, 2018

bodedra left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bizzappdev commented Nov 26, 2018

bodedra left a comment

Choose a reason for hiding this comment

nikul-serpentcs commented Dec 22, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikul-serpentcs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bizzappdev Dec 24, 2018 • edited Loading

Choose a reason for hiding this comment

nikul-serpentcs commented Dec 24, 2018

bizzappdev commented Jan 30, 2019

pedrobaeza commented Jan 30, 2019

nikul-serpentcs commented Jan 30, 2019

bizzappdev commented Jan 30, 2019

rousseldenis left a comment

Choose a reason for hiding this comment

bizzappdev Dec 24, 2018 •

edited

Loading