Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG]Migrate stock_picking_customer_ref #476

Merged
merged 11 commits into from
Feb 6, 2019

Conversation

bizzappdev
Copy link
Contributor

Migrate stock_picking_customer_ref from v11 to v12
#457

@rousseldenis rousseldenis added this to the 12.0 milestone Nov 24, 2018
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 24, 2018
34 tasks
@pedrobaeza
Copy link
Member

pedrobaeza commented Nov 24, 2018

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-12.0

@bizzappdev bizzappdev force-pushed the 12.0-mig-stock_picking_customer_ref branch from 0e1b90b to 93eee7c Compare November 25, 2018 04:37
@oca-clabot
Copy link

Hey @bizzappdev, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

  • andreas [email protected] (no github login found)
  • alfredo <alfredo@alfredo-aspire-5738.(none)> (no github login found)

Appreciation of efforts,
OCA CLAbot

@bizzappdev
Copy link
Contributor Author

sorry for my lack of knowledge. commit history has been added

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review over the README

stock_picking_customer_ref/README.rst Outdated Show resolved Hide resolved
stock_picking_customer_ref/README.rst Outdated Show resolved Hide resolved
@oca-clabot
Copy link

Hey @bizzappdev, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

  • andreas [email protected] (no github login found)
  • alfredo <alfredo@alfredo-aspire-5738.(none)> (no github login found)

Appreciation of efforts,
OCA CLAbot

@bizzappdev
Copy link
Contributor Author

changes are done

@rousseldenis
Copy link
Contributor

@pedrobaeza

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@oca-clabot
Copy link

Hey @bizzappdev, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

3 similar comments
@oca-clabot
Copy link

Hey @bizzappdev, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@oca-clabot
Copy link

Hey @bizzappdev, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@oca-clabot
Copy link

Hey @bizzappdev, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve Code

stock_picking_customer_ref/__manifest__.py Outdated Show resolved Hide resolved
@nikul-serpentcs
Copy link
Member

@bizzappdev Use new README by fragment system, copying https://github.com/OCA/maintainer-tools/tree/master/template/module/readme and editing or removing the needed sections. You can then run locally oca-gen-addon-readme if you have OCA/maintainer-tools installed and you want to pre-generate the README.rst file (preferred), or keep the previous README.rst file.

@oca-clabot
Copy link

Hey @bizzappdev, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@bizzappdev
Copy link
Contributor Author

@bizzappdev Use new README by fragment system, copying https://github.com/OCA/maintainer-tools/tree/master/template/module/readme and editing or removing the needed sections. You can then run locally oca-gen-addon-readme if you have OCA/maintainer-tools installed and you want to pre-generate the README.rst file (preferred), or keep the previous README.rst file.

Changes are done

@nikul-serpentcs
Copy link
Member

@bizzappdev squash commits

Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't you need to change the PO files too?

@bizzappdev
Copy link
Contributor Author

PO file changed.

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. could you squash your commits ?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@bizzappdev
Copy link
Contributor Author

squash commits is done and also remove bizzappdev as author.

@bizzappdev bizzappdev force-pushed the 12.0-mig-stock_picking_customer_ref branch from d2adb30 to d87d72e Compare February 6, 2019 14:01
@pedrobaeza pedrobaeza merged commit 7f29814 into OCA:12.0 Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.