Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][16.0] stock_scrap_tier_validation #1867

Open
wants to merge 20 commits into
base: 16.0
Choose a base branch
from
Open

[MIG][16.0] stock_scrap_tier_validation #1867

wants to merge 20 commits into from

Conversation

em230418
Copy link

@em230418 em230418 commented Feb 4, 2025

No description provided.

alan196 and others added 17 commits February 4, 2025 16:41
@alan196 @em230418
[ADD] stock_scrap_tier_validation: new module to add tier validation …
fe678e4 
…to stock.scrap
@em230418
[UPD] Update stock_scrap_tier_validation.pot
d292bf7
@OCA-git-bot @em230418
[UPD] README.rst
fb10c0e
@OCA-git-bot @em230418
[ADD] icon.png
3d4132c
@OCA-git-bot @em230418
[UPD] README.rst
0555ca1
@em230418
[UPD] Update stock_scrap_tier_validation.pot
09808e6
@Ivorra78 @em230418
Added translation using Weblate (Spanish)
f034551
@Ivorra78 @em230418
Translated using Weblate (Spanish)
22b9e81 
Currently translated at 100.0% (19 of 19 strings)

Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_scrap_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_scrap_tier_validation/es/
@weblate @em230418
Update translation files
7b1071e 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_scrap_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_scrap_tier_validation/
@Ivorra78 @em230418
Translated using Weblate (Spanish)
ff5f59d 
Currently translated at 100.0% (20 of 20 strings)

Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_scrap_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_scrap_tier_validation/es/
@mymage @em230418
Added translation using Weblate (Italian)
71985c4
@mymage @em230418
Translated using Weblate (Italian)
8f8fa63 
Currently translated at 100.0% (20 of 20 strings)

Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_scrap_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_scrap_tier_validation/it/
@mymage @em230418
Translated using Weblate (Italian)
1324663 
Currently translated at 100.0% (20 of 20 strings)

Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_scrap_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_scrap_tier_validation/it/
@mymage @em230418
Translated using Weblate (Italian)
9b45f16 
Currently translated at 100.0% (20 of 20 strings)

Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_scrap_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_scrap_tier_validation/it/
@mymage @em230418
Translated using Weblate (Italian)
004136b 
Currently translated at 100.0% (20 of 20 strings)

Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_scrap_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_scrap_tier_validation/it/
@em230418
[IMP] stock_scrap_tier_validation: pre-commit auto fixes
b46952d
@em230418
[MIG] stock_scrap_tier_validation: Migration to 16.0
1c4f350
@em230418 em230418 mentioned this pull request Feb 4, 2025
Closed
@em230418 em230418 marked this pull request as ready for review February 4, 2025 12:01
StefanRijnhart
StefanRijnhart requested changes Feb 4, 2025
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is one of the issues I solved in the earlier migration to 17.0: create a tier definition for stock.scrap. Go to a delivery transfer. Click the Scrap button. You get this error:
image

It is because the 'secondary' stock scrap popup view does not have the tier validation fields. This is solved in 9abffe9#diff-635ed623ad5aeed8a01ed21e71441fd81a5697bec804f2581bf843ecfea40d94. I really think you will want to take the rest of that commit as well, to prevent the other issue from showing up (the other issue being: the popup is only saved upon confirmation, but the confirmation is blocked because of the validation, resulting in a deadlock).

@em230418 em230418 force-pushed the 16.0-mig2-stock_scrap_tier_validation branch from e0ecee7 to 20b4b25 Compare February 5, 2025 09:16
@em230418 em230418 marked this pull request as draft February 5, 2025 09:27
@StefanRijnhart @em230418
[FIX] stock_scrap_tier_validation: workaround added to escape client …
61c2ddc 
…error when pressing scrap from picking

Co-authored-by: Eugene Molotov <[email protected]>
@em230418 em230418 force-pushed the 16.0-mig2-stock_scrap_tier_validation branch from 20b4b25 to 61c2ddc Compare February 5, 2025 09:52
@em230418 em230418 marked this pull request as ready for review February 5, 2025 09:57
StefanRijnhart
StefanRijnhart requested changes Feb 5, 2025
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scrapping from stock picking now works, but you did not take the *_mrp glue module from my commit so predictably, scrapping from an mrp.production form still halts on the deadlock described above if validation is required.
image

@em230418
Copy link
Author

em230418 commented Feb 5, 2025

Cherry-picked [ADD] stock_scrap_tier_validation_mrp from 17.0
Did not check if it works fine

@rousseldenis
Copy link
Contributor

/ocabot migration stock_scrap_tier_validation

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Feb 5, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 5, 2025
Open
71 tasks
@StefanRijnhart
Copy link
Member

Did not check if it works fine

@em230418 That's quite a confession. I really wouldn't like running into issues testing a third time on this PR. Are you sure you don't want to have a go first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanRijnhart StefanRijnhart Awaiting requested review from StefanRijnhart

Assignees
No one assigned
Labels
migration needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
8 participants
@em230418 @rousseldenis @StefanRijnhart @OCA-git-bot @alan196 @Ivorra78 @weblate @mymage