Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] stock_picking_auto_create_lot_sequence #1865

Open
wants to merge 8 commits into
base: 17.0
Choose a base branch
from

Conversation

Tisho99
Copy link

@Tisho99 Tisho99 commented Feb 3, 2025

Standard migration

Test simplified because self.picking.button_validate() no longer returns a wizard

This PR depends on OCA/product-attribute#1708

T-7432

@Tisho99 Tisho99 marked this pull request as draft February 4, 2025 08:56
@Tisho99 Tisho99 mentioned this pull request Feb 4, 2025
67 tasks
@Tisho99 Tisho99 force-pushed the 17.0-mig-stock_picking_auto_create_lot_sequence branch from 8f5983a to 7e8476c Compare February 4, 2025 09:46
@Tisho99 Tisho99 marked this pull request as ready for review February 4, 2025 09:52
@Tisho99
Copy link
Author

Tisho99 commented Feb 4, 2025

Copy link

@manuelregidor manuelregidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review. LGTM

@rousseldenis
Copy link
Contributor

/ocabot migration stock_picking_auto_create_lot_sequence

Copy link

@sara-castello sara-castello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM

Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. what about this? @Tisho99 @manuelregidor

Captura de pantalla 2025-02-05 a las 9 38 45

@Tisho99
Copy link
Author

Tisho99 commented Feb 5, 2025

@HaraldPanten
Copy link

@HaraldPanten

We have to wait for this PR to be completed and merged:

OCA/product-attribute#1708

https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

@Tisho99 OK!

Could you update your first comment in the PR and add this info? It's easier for the reviewers if you add something like:

This PR depends on OCA/product-attribute#1708

THX!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants