[FIX] stock_no_negative: use display_name instead of name_get because it is deprecated #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rousseldenis
requested changes
Jan 31, 2025
| @@ -39,7 +39,7 @@ def check_negative_qty(self): | |||
| ): | |||
| msg_add = "" | |||
| if quant.lot_id: | |||
| msg_add = _(" lot {}").format(quant.lot_id.name_get()[0][1]) | |||
| msg_add = _(" lot {}").format(quant.lot_id.display_name) | |||
There was a problem hiding this comment.
Could you remove also format() method and use translation function arguments instead ?
Suggested change
| msg_add = _(" lot {}").format(quant.lot_id.display_name) | |
| msg_add = _(" lot %(name)s", name=quant.lot_id.display_name) |
And add a test to avoid regression ? Thanks
There was a problem hiding this comment.
Hello, i changed the format function.
How should i create the test ? Should i assert the FULL ValidationError message content ?
the msg_add is used in a dynamic string passed to a validation error
micheledic
force-pushed
the
18.0_fix_stock_no_negative
branch
from
44d9a28 to
6e7e146
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name_get is deprecated the error
AttributeError: 'stock.lot' object has no attribute 'name_get'appear