Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] stock_split_picking: Migration to version 18.0 #1857

Open
wants to merge 61 commits into
base: 18.0
Choose a base branch
from
Open

[MIG] stock_split_picking: Migration to version 18.0 #1857

wants to merge 61 commits into from

Conversation

gbrito
Copy link

@gbrito gbrito commented Jan 29, 2025

No description provided.

guewen and others added 30 commits January 29, 2025 15:30
@guewen @gbrito
[MRG] from master branch
b1c1afb 
(/home/jgrandguillaume/c2c/ProjetsEC/IFRC/Code/openerp_70_ifrc_core_dev/parts/generic-addons rev 29.1.1)
@guewen @gbrito
[FIX] prevents a KeyError is the context is None
9a7446d 
(/home/jgrandguillaume/c2c/ProjetsEC/IFRC/Code/openerp_70_ifrc_core_dev/parts/generic-addons rev 29.1.14)
@nbessi @gbrito
[FIX] donor in manifest
4111d98
@gurneyalex @gbrito
spellchecking
df1a895
@guewen @gbrito
Display the split button when the delivery order is in draft, waiting…
012d160 
… availability or ready to deliver
@gurneyalex @gbrito
mark unported module as uninstallable
d79adef
@yvaucher @gbrito
Reactivate stock_split_picking
1f39dfc
@yvaucher @gbrito
remove stock.picking.out
69bc4ac
@yvaucher @gbrito
Port to 8.0
6d5de17
@yvaucher @gbrito
Adapt tests
363bd97
@guewen @gbrito
Split procurements as well when a move is split
49612e6 
Both procurements will still be split to the sale order line.
If one of the picking is canceled, the whole sale order will be in
'shipping_exception'.
@guewen @gbrito
Allow to split a partially available picking
91993d1
@gurneyalex @gbrito
also show split button on incoming moves
75f396a
@gurneyalex @gbrito
handle reservations
d9425b6 
when splitting a move with reservations, they have to be recomputed.
code inspired from the implementation of stock_picking.rereserve_quants

split the tests in travis.yml because another module is changing the states we get
with only stock_split_picking installed

fix a bug in stock_ownership_by_move which would cause wrong pack operations to
be generated
@sbidoul @gbrito
[UPD] prefix versions with 8.0
27e517e
@pedrobaeza @gbrito
[MIG] Make modules uninstallable
05b3152
@pedrobaeza @gbrito
[MIG] Rename manifest files
b9ebd80
@oihane @gbrito
stock_split_picking: test error
f8aff21
@gbrito
stock_split_picking : open action instead of create wizard
9449507
@gbrito
allow split on internal picking]
0dc86c2
@cubells @gbrito
[MIG][10.0] stock_split_picking module
66a31e1
@cubells @gbrito
Improve coverage
a14bf6a
@jcoux @gbrito
[MIG][11.0] stock_split_picking
1367fc9
@sbidoul @gbrito
remove obsolete .pot files [ci skip]
67ac4c8
@gbrito
[MIG] stock_split_picking: Migration to 12.0
e945372
@gbrito
[MIG] stock_split_picking: Pre-commit to 13.0
5964cbf
@gbrito
[MIG] stock_split_picking: Migration to 13.0
80060b4
@hbrunn @gbrito
[ADD] stock_split_picking: Mode selection to split in different ways
3d15a4c
@RujiaL @gbrito
[IMP] stock_split_picking: black, isort, prettier
f2ad98b
@RujiaL @gbrito
[MIG] stock_split_picking: Migration to 14.0
b2ff09e
Ivorra78 and others added 12 commits January 29, 2025 15:30
@Ivorra78 @gbrito
Translated using Weblate (Spanish)
2596da3 
Currently translated at 100.0% (26 of 26 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_split_picking
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_split_picking/es/
@OCA-git-bot @gbrito
[UPD] README.rst
9d0fe96
@mymage @gbrito
Translated using Weblate (Italian)
ce6a4db 
Currently translated at 100.0% (26 of 26 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_split_picking
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_split_picking/it/
@rven @gbrito
[IMP] stock_split_picking: pre-commit stuff
3342e1d
@rven @gbrito
[MIG] stock_split_picking: Migration to 17.0
6b2d1e7
@gbrito
[UPD] Update stock_split_picking.pot
4ef6f25
@OCA-git-bot @gbrito
[BOT] post-merge updates
34eef12
@weblate @gbrito
Update translation files
bc55914 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-17.0/stock-logistics-workflow-17.0-stock_split_picking
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-17-0/stock-logistics-workflow-17-0-stock_split_picking/
@mymage @gbrito
Translated using Weblate (Italian)
ce9bbf9 
Currently translated at 100.0% (25 of 25 strings)

Translation: stock-logistics-workflow-17.0/stock-logistics-workflow-17.0-stock_split_picking
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-17-0/stock-logistics-workflow-17-0-stock_split_picking/it/
@Ivorra78 @gbrito
Translated using Weblate (Spanish)
bad56b4 
Currently translated at 100.0% (25 of 25 strings)

Translation: stock-logistics-workflow-17.0/stock-logistics-workflow-17.0-stock_split_picking
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-17-0/stock-logistics-workflow-17-0-stock_split_picking/es/
@epanisset @gbrito
Translated using Weblate (French)
981d7b5 
Currently translated at 100.0% (25 of 25 strings)

Translation: stock-logistics-workflow-17.0/stock-logistics-workflow-17.0-stock_split_picking
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-17-0/stock-logistics-workflow-17-0-stock_split_picking/fr/
@gbrito
[IMP] stock_split_picking: pre-commit stuff
e877bfe
StefanRijnhart
StefanRijnhart approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StefanRijnhart
Copy link
Member

/ocabot migration stock_split_picking

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jan 30, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 30, 2025
Open
40 tasks
bosd
bosd suggested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test ok 👍
Small improvement on doc. It is no longer restricted to outgoing pickings. I was looking for something like this for incoming.

Please fix the Pre-commit, then we can go! 🟢

stock_split_picking/readme/DESCRIPTION.md Outdated
@@ -0,0 +1,8 @@
This module adds a "Split" button on the outgoing pickings form.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This module adds a "Split" button on the outgoing pickings form.
This module adds a "Split" button on the pickings form.

@gbrito gbrito force-pushed the 18.0-mig-stock_split_picking branch from fd5ca6d to 67d23df Compare January 31, 2025 07:45
@gbrito gbrito requested a review from bosd January 31, 2025 07:45
@gbrito
Copy link
Author

gbrito commented Jan 31, 2025

@bosd @StefanRijnhart Just pushed the requested changes

Really appreciate the interaction, do you guys mind if I tag you in future PR ?

StefanRijnhart
StefanRijnhart approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbrito Sorry, not a big fan of tagging. It could get out of hand real quickly.

bosd
bosd approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 💯

jbaudoux
jbaudoux requested changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the module migration

Can you include those fixes from v16:

And this PR #1788 is befing fixed and soon merged. You'll be able to integrate it as well

@StefanRijnhart
Copy link
Member

@jbaudoux About #1788: it's not being followed up by its author and there are changes requested. I don't think it qualifies for inclusion at this point.

@rousseldenis
Copy link
Contributor

@jbaudoux About #1788: it's not being followed up by its author and there are changes requested. I don't think it qualifies for inclusion at this point.

I check this now

@StefanRijnhart
Copy link
Member

OK, #1788 is also ready to be included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaudoux jbaudoux jbaudoux requested changes

@bosd bosd bosd approved these changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.