[18.0][MIG] stock_picking_batch_extended: Migration to 18.0 #1855

yankinmax · 2025-01-28T11:06:34Z

No description provided.

…eed it

- Converts old stock.batch.picking in stock.picking.batch - Restore link in stock.picking - Other needed stuff

…er and activities

…ckings

* Standard procedure * Fix tests

…or small screens.

… in tree view TT28975

…buttons. TT30796

… pickings

Currently translated at 21.4% (15 of 70 strings) Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_picking_batch_extended Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_picking_batch_extended/it/

Currently translated at 87.1% (61 of 70 strings) Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_picking_batch_extended Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_picking_batch_extended/sl/

…w in batch pickings

… Use _for_xml_id instad of read

…g mode is selected. Don't save last option when batch_by_group is unchecked. TT42965 TT43055

…ression

…Picking group [REF] stock_picking_batch_extended: update picking_batch_configuration_settings img configuration

Currently translated at 22.2% (14 of 63 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_batch_extended Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_batch_extended/it/

Currently translated at 100.0% (63 of 63 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_batch_extended Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_batch_extended/it/

Currently translated at 84.1% (53 of 63 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_batch_extended Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_batch_extended/pt_BR/

Currently translated at 100.0% (63 of 63 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_batch_extended Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_batch_extended/it/

Currently translated at 100.0% (63 of 63 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_batch_extended Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_batch_extended/pt_BR/

Currently translated at 100.0% (63 of 63 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_batch_extended Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_batch_extended/it/

…icking report on "print deliveries" button TT50661

yankinmax · 2025-01-28T11:44:08Z

stock_picking_batch_extended/migrations/18.0.1.0.0/pre-migrate.py

+#  License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+
+
+def migrate(cr, version):


This migration script is needed to handle the return to an existent field description_picking from custom description_warehouse
It was requested in TODO

yankinmax · 2025-01-28T11:44:41Z

stock_picking_batch_extended/models/product_product.py

-    # TODO: Integrate in existent field
-    description_warehouse = fields.Text("Warehouse Description", translate=True)


I suppose description_picking is the field we want to return to

yankinmax · 2025-01-28T11:46:00Z

stock_picking_batch_extended/tests/test_batch.py

-                            "product_uom_qty": 1,
-                            "location_id": cls.stock_loc.id,
-                            "location_dest_id": cls.customer_loc.id,
+                            "product_uom_qty": 10,


I propose to increase the quantity to easily simulate partial and backorder usage behavior

yankinmax · 2025-01-28T11:49:44Z

stock_picking_batch_extended/tests/test_batch.py

@@ -256,8 +264,7 @@ def test_backorder(self):
        self.assertEqual(self.product6, backorder.move_ids[0].product_id)
        self.assertEqual(2, backorder.move_ids[0].product_uom_qty)
        self.assertEqual(1, len(backorder.move_line_ids))
-        self.assertEqual(2, backorder.move_line_ids[0].reserved_uom_qty)
-        self.assertEqual(0, backorder.move_line_ids[0].qty_done)


qty_done is not an attribute of stock.move.line anymore

yankinmax · 2025-01-28T11:51:04Z

stock_picking_batch_extended/tests/test_batch.py


    def test_package(self):
-        warehouse = self.browse_ref("stock.warehouse0")


This test was failing. I've checked the OCA code doesn't modify the behavior of packaging, so I've rewritten the code with the standard way.

yankinmax · 2025-01-28T11:51:55Z

stock_picking_batch_extended/wizard/stock_picking_to_batch.py

@@ -168,24 +168,3 @@ def action_view_batch_picking(self, batch_pickings):
        else:
            action = batch_pickings.get_formview_action()
        return action
-
-
-class StockBatchPickingCreatorGroupField(models.TransientModel):


Following conventions I've moved this class definition to a separate file.

yankinmax · 2025-01-28T11:52:17Z

stock_picking_batch_extended/models/res_config_settings.py

@@ -12,9 +12,3 @@ class ResConfigSettings(models.TransientModel):
        related="company_id.use_oca_batch_validation",
        readonly=False,
    )
-
-
-class Company(models.Model):


Following conventions I've moved this class definition to a separate file.

rousseldenis · 2025-01-28T12:37:03Z

/ocabot migration stock_picking_batch_extended

rousseldenis · 2025-01-28T12:40:16Z

stock_picking_batch_extended/readme/CONFIGURE.md

@@ -0,0 +1,6 @@
+In Inventory / Settings / Batch Picking it is possible to activate or
+deactivate which approach for batch handling will be used per company.


It should be great to describe which one.

gaetan-vaujour

Functional validation is OK

rousseldenis · 2025-01-30T07:33:47Z

IMHO those kind of modules should be avoided. As it is very difficult for users to determine what is the real purpose of it.

jbaudoux

Warf! This module is doing too many different things.
Can you split in several modules? One meaningful group of features per module.
And try to find meaningful module names

jbaudoux · 2025-01-31T13:19:45Z

stock_picking_batch_extended/models/product_product.py

+class ProductTemplate(models.Model):
+    _inherit = "product.template"
+
+    description_picking = fields.Text(string="Warehouse Description", translate=True)


I don't see where this is used. Should be in a separate module

jbaudoux · 2025-01-31T13:20:19Z

stock_picking_batch_extended/models/res_company.py

+class Company(models.Model):
+    _inherit = "res.company"
+
+    use_oca_batch_validation = fields.Boolean()


What is the OCA way? This is not clear, help missing. Rename field

Iryna Vyshnevska and others added 30 commits January 27, 2025 10:51

[FIX] stock_picking_mass_action return backorder if any of pickings n…

fd7b27d

…eed it

[12.0][FIX] stock_picking_batch_extended

39f72d9

[MIG] stock_picking_batch_extended: Migration scripts

5b6ff38

- Converts old stock.batch.picking in stock.picking.batch - Restore link in stock.picking - Other needed stuff

[FIX] stock_picking_batch_extended: float_is_zero required parameters

460caec

[IMP] stock_picking_batch_extended: UX improvements

f622b99

[IMP] stock_picking_batch_extended: Add followers, attachments, chatt…

85d6a8b

…er and activities

[IMP] stock_picking_batch_extended: Request confirmation to cancel pi…

231490c

…ckings

[IMP] stock_picking_batch_extended: black, isort, prettier

41e138a

[MIG] stock_picking_batch_extended: Migration to 13.0

d8a696f

* Standard procedure * Fix tests

[IMP] stock_picking_batch_extended: Add kanban view in batch action f…

68c8209

…or small screens.

stock_picking_batch_extended 13.0.1.1.0

b83a6c6

[IMP] stock_picking_batch_extended: Add optional picking_count column…

91fa013

… in tree view TT28975

stock_picking_batch_extended 13.0.1.2.0

f77b2ba

[IMP] stock_picking_batch_extended: Add confirm to validate and done …

670fe69

…buttons. TT30796

stock_picking_batch_extended 13.0.1.3.0

6593163

[IMP] stock_picking_batch_extended: black, isort, prettier

6741982

[MIG] [14.0] stock_picking_batch_extended: Migration to 14.0

b045dae

[IMP] add post-init hook to apply settings

9e660df

[MIG] stock_picking_batch_extended: Migration to 15.0

b328d10

[IMP] stock_picking_batch_extended: Refactor. Odoo has improved batch…

0960f0d

… pickings

[UPD] Update stock_picking_batch_extended.pot

b81ea70

[IMP] stock_picking_batch_extended: Display standard picking tree vie…

a7a323a

…w in batch pickings

[FIX] stock_picking_batch_extended: Administration settings required.…

2b4384e

… Use _for_xml_id instad of read

stock_picking_batch_extended 15.0.2.0.1

45ee5d8

stock_picking_batch_extended 15.0.2.1.0

ecb2a45

[IMP] stock_picking_batch_extended: Display batch picking in form view

e49958a

stock_picking_batch_extended 15.0.2.2.0

e2cc5af

[FIX] stock_picking_batch_extended: New batch is created when existin…

dc9fc57

…g mode is selected. Don't save last option when batch_by_group is unchecked. TT42965 TT43055

RodrigoBM and others added 13 commits January 27, 2025 10:52

[REF] stock_picking_batch_extended: readme is changed for better comp…

794b80d

…ression

[REF] stock_picking_batch_extended: Move settings option under Batch …

c450435

…Picking group [REF] stock_picking_batch_extended: update picking_batch_configuration_settings img configuration

[FIX] stock_picking_batch_extended: Printed batch report instead of p…

208da54

…icking report on "print deliveries" button TT50661

[IMP] stock_picking_batch_extended: pre-commit auto fixes

a3a7973

[MIG] stock_picking_batch_extended: Migration to 18.0

3d36345

yankinmax force-pushed the 18.0-mig-stock_picking_batch_extended branch from 13ea03a to 3d36345 Compare January 28, 2025 11:29

yankinmax commented Jan 28, 2025

View reviewed changes

OCA-git-bot added this to the 18.0 milestone Jan 28, 2025

rousseldenis added needs review migration labels Jan 28, 2025

OCA-git-bot mentioned this pull request Jan 28, 2025

Migration to version 18.0 #1737

Open

40 tasks

rousseldenis reviewed Jan 28, 2025

View reviewed changes

gaetan-vaujour approved these changes Jan 29, 2025

View reviewed changes

jbaudoux requested changes Jan 31, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] stock_picking_batch_extended: Migration to 18.0 #1855

[18.0][MIG] stock_picking_batch_extended: Migration to 18.0 #1855

yankinmax commented Jan 28, 2025

yankinmax Jan 28, 2025

yankinmax Jan 28, 2025

yankinmax Jan 28, 2025

yankinmax Jan 28, 2025

yankinmax Jan 28, 2025

yankinmax Jan 28, 2025

yankinmax Jan 28, 2025

rousseldenis commented Jan 28, 2025

rousseldenis Jan 28, 2025

gaetan-vaujour left a comment •

edited

Loading

rousseldenis commented Jan 30, 2025

jbaudoux left a comment

jbaudoux Jan 31, 2025

jbaudoux Jan 31, 2025

		# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).


		def migrate(cr, version):

		# TODO: Integrate in existent field
		description_warehouse = fields.Text("Warehouse Description", translate=True)


		def test_package(self):
		warehouse = self.browse_ref("stock.warehouse0")

		@@ -0,0 +1,6 @@
		In Inventory / Settings / Batch Picking it is possible to activate or
		deactivate which approach for batch handling will be used per company.

[18.0][MIG] stock_picking_batch_extended: Migration to 18.0 #1855

Are you sure you want to change the base?

[18.0][MIG] stock_picking_batch_extended: Migration to 18.0 #1855

Conversation

yankinmax commented Jan 28, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rousseldenis commented Jan 28, 2025

Choose a reason for hiding this comment

gaetan-vaujour left a comment • edited Loading

Choose a reason for hiding this comment

rousseldenis commented Jan 30, 2025

jbaudoux left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaetan-vaujour left a comment •

edited

Loading