Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] Add stock_split_picking_kit #1829

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

TDu
Copy link
Member

@TDu TDu commented Jan 13, 2025

No description provided.

@TDu TDu force-pushed the 14-add-stock_split_picking_kit branch from f93ff2d to 988cd51 Compare January 13, 2025 14:25
stock_split_picking_kit/__manifest__.py Outdated Show resolved Hide resolved
stock_split_picking_kit/wizards/stock_split_picking.py Outdated Show resolved Hide resolved
stock_split_picking_kit/wizards/stock_split_picking.py Outdated Show resolved Hide resolved
new_move_vals = []
for move in moves:
new_move_vals += move._split(
move.bom_line_id.product_qty * kit_to_split
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at the bom_line_id.product_qty, why going through the complex _compute_kit_quantities ?
kit_quantity = move.product_qty / move.bom_line_id.product_qty

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it makes sure that the computed kits are complete.

stock_split_picking_kit/wizards/stock_split_picking.py Outdated Show resolved Hide resolved
@TDu TDu force-pushed the 14-add-stock_split_picking_kit branch from 3489641 to 248a32e Compare January 17, 2025 08:34
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG :)
Can you squash fixups?

@TDu TDu force-pushed the 14-add-stock_split_picking_kit branch from 8124c8c to a2d3208 Compare February 5, 2025 08:10
@TDu
Copy link
Member Author

TDu commented Feb 5, 2025

LG :) Can you squash fixups?

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants