Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] stock_picking_mass_action: Migration to version 16.0 #1405

Merged
merged 16 commits into from
Dec 4, 2023
Merged

[16.0][MIG] stock_picking_mass_action: Migration to version 16.0 #1405

merged 16 commits into from
Dec 4, 2023

Conversation

carolinafernandez-tecnativa
Copy link
Contributor

TT44366

@Tecnativa

@pedrobaeza @carlosdauden

@rousseldenis
Copy link
Contributor

/ocabot migration stock_picking_mass_action

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 19, 2023
@OCA-git-bot
Copy link
Contributor

The migration issue (#1101) has not been updated to reference the current pull request because a previous pull request (#1308) is not closed.
Perhaps you should check that there is no duplicate work.
CC @pausanchezqubiq

@rousseldenis rousseldenis mentioned this pull request Oct 19, 2023
Closed
@rousseldenis
Copy link
Contributor

@carolinafernandez-tecnativa Thanks for this. Usually, when a PR exists, it is fair to start from there (and crediting contributor).

@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 16.0-mig-stock_picking_mass_action branch from a78b57b to 6459816 Compare October 20, 2023 12:00
@carolinafernandez-tecnativa
Copy link
Contributor Author

@carolinafernandez-tecnativa Thanks for this. Usually, when a PR exists, it is fair to start from there (and crediting contributor).

Thanks! I just added the contributor as in other PR

@pedrobaeza
Copy link
Member

@rousseldenis was talking about cherry-picking their commit, not to add it as contributor in the README (which can also be done, of course).

@pedrobaeza
Copy link
Member

I still see your changes as predominant. You should:

  • Remove your commit (you can save the contents).
  • Cherry-pick the other commit.
  • Add your changes and commit.

legalsylvain and others added 14 commits November 13, 2023 12:01
@legalsylvain @carolinafernandez-tecnativa
[PORT] from V7, stock_picking_mass_assign renamed into stock_picking_…
67d2e31 
…mass_action

[FIX] dependencies + context loose
[FIX] pylint ; REF : remove useless control
@cubells @carolinafernandez-tecnativa
[MIG] stock_picking_mass_action: migration to 10.0
580c45d
@carolinafernandez-tecnativa
[MIG] 11.0 stock_picking_mass_action
f612d50
@carlosdauden @carolinafernandez-tecnativa
[IMP] stock_picking_mass_action: Fix and improve transfer method
a8aefa4
@carlosdauden @carolinafernandez-tecnativa
[MIG] stock_picking_mass_action: Migration to 12.0
1a5eb20
@carolinafernandez-tecnativa
[FIX] stock_picking_mass_action return backorder if any of pickings n…
dfb4732 
…eed it
@carolinafernandez-tecnativa
fixup! [FIX] stock_picking_mass_action return backorder if any of pic…
206dbf0 
…kings need it
@carlosdauden @carolinafernandez-tecnativa
[IMP] stock_picking_mass_action: Remove force availability in readme
a29b62b
@sergio-teruel @carolinafernandez-tecnativa
[IMP] stock_picking_mass_action: black, isort
fece533
@sergio-teruel @carolinafernandez-tecnativa
[MIG] stock_picking_mass_action: Migration to v13.0
78d15b2
@sbejaoui @carolinafernandez-tecnativa
[14.0][MIG] - stock_picking_mass_action
f4d9a0f
@carolinafernandez-tecnativa
Fix button_validate action
12061a0
@theangryangel @carolinafernandez-tecnativa
[MIG] stock_picking_mass_action: Migration to 15.0
5ca8e4d
@victoralmau @carolinafernandez-tecnativa
[FIX] stock_picking_mass_action: Change SavepointCase to TransactionCase
9684469
@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 16.0-mig-stock_picking_mass_action branch from fa305e2 to 5706081 Compare November 13, 2023 15:11
@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 16.0-mig-stock_picking_mass_action branch from 5706081 to 630bb6f Compare November 13, 2023 15:47
@carolinafernandez-tecnativa
Copy link
Contributor Author

I still see your changes as predominant. You should:

  • Remove your commit (you can save the contents).
  • Cherry-pick the other commit.
  • Add your changes and commit.

Could you please check it now? Thanks :)

@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 16.0-mig-stock_picking_mass_action branch from 630bb6f to 7a0a48e Compare November 13, 2023 15:54
@FranciscoFactorLibre
Copy link
Contributor

I have carried out a functional review, and it seems correct.

Can you check from your side @carlosdauden ?

Thanks

@legalsylvain
Copy link
Contributor

@FranciscoFactorLibre, could you approve via github, to make the PR approved ?

FranciscoFactorLibre
FranciscoFactorLibre approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@FranciscoFactorLibre FranciscoFactorLibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have carried out a functional review, and it seems correct.

Thanks

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1405-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 74688ba into OCA:16.0 Dec 4, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1149867. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-mig-stock_picking_mass_action branch December 4, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@FranciscoFactorLibre FranciscoFactorLibre FranciscoFactorLibre approved these changes

@carlosdauden carlosdauden Awaiting requested review from carlosdauden

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.