Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] stock_partner_delivery_window #1378

Merged
merged 25 commits into from
Oct 10, 2023
Merged

[16.0][ADD] stock_partner_delivery_window #1378

merged 25 commits into from
Oct 10, 2023

Conversation

nguyenminhchien
Copy link
Contributor

@nguyenminhchien nguyenminhchien commented Sep 19, 2023 •
edited
Loading

@nguyenminhchien nguyenminhchien mentioned this pull request Sep 19, 2023
Merged
4 tasks
@nguyenminhchien nguyenminhchien marked this pull request as ready for review September 20, 2023 03:50
@nguyenminhchien nguyenminhchien mentioned this pull request Sep 20, 2023
Closed
@rousseldenis
Copy link
Contributor

/ocabot migration stock_partner_delivery_window

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 20, 2023
@OCA-git-bot
Copy link
Contributor

The migration issue (#1101) has not been updated to reference the current pull request because a previous pull request (#1332) is not closed.
Perhaps you should check that there is no duplicate work.
CC @heliaktiv

cyrilmanuel
cyrilmanuel approved these changes Sep 21, 2023
View reviewed changes
Copy link

@cyrilmanuel cyrilmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not an expert but LGTM

jbaudoux
jbaudoux reviewed Sep 26, 2023
View reviewed changes
jbaudoux
jbaudoux requested changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2 dropped methods on res_partner should be recovered

grindtildeath and others added 18 commits September 26, 2023 18:02
@grindtildeath @nguyenminhchien
Add stock_partner_delivery_window
ad55c25
@dzungtran89 @nguyenminhchien
[IMP] stock_partner_delivery_window: black, isort, prettier
be78d59
@dzungtran89 @nguyenminhchien
[MIG] stock_partner_delivery_window: Migration to 14.0
276bc01
@sebalix @nguyenminhchien
s_p_delivery_window: time format improvements
86eb548 
Two small improvements:

* add a hook to change the delivery time format
* no need to display seconds, hh:mm is enough
@simahawk @nguyenminhchien
stock_partner_delivery_window: ease warning msg check/override
8ed3320
@mmequignon @nguyenminhchien
stock_partner_delivery_window: Cleanup
8464cfa
@mmequignon @nguyenminhchien
s_p_delivery_window: Add working days as delivery schedule preference
3942d7d
@grindtildeath @nguyenminhchien
[FW][14.0] stock_partner_delivery_window: Fix default value on delive…
e4e353c 
…ry_time_preference

The default value introduced by workdays feature breaks the installation
of Demo databases as the change is not reflected in sale_partner_delivery_window.
@oca-travis @nguyenminhchien
[UPD] Update stock_partner_delivery_window.pot
cdb6d76
@OCA-git-bot @nguyenminhchien
[ADD] icon.png
a0ba5cc
@OCA-git-bot @nguyenminhchien
stock_partner_delivery_window 14.0.1.0.1
7d3072e
@sebalix @nguyenminhchien
[FIX] s_p_delivery_window: selection attribute will be ignored as the…
fd251b5 
… field is related
@OCA-git-bot @nguyenminhchien
stock_partner_delivery_window 14.0.1.1.0
e5949c7
@gurneyalex @nguyenminhchien
[FIX] stock_partner_delivery_window version
b4129da 
version conflict prevents upload to pypi
@hailangvn @nguyenminhchien
[IMP] stock_partner_delivery_window: copy time window ids of partner
dc948bf 
When copying partner, if the partner's delivery time preference is time
window, time window ids should be copied as well.
@OCA-git-bot @nguyenminhchien
stock_partner_delivery_window 14.0.1.2.0
6fff0f9
@rousseldenis @nguyenminhchien
[14.0][FIX] Align development statuses
242b5d4
@OCA-git-bot @nguyenminhchien
[UPD] README.rst
48984e9
@nguyenminhchien nguyenminhchien force-pushed the 16.0-mig-stock_partner_delivery_window branch from 6697349 to 18daa31 Compare September 26, 2023 11:34
simahawk
simahawk approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1378-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 80f4834 into OCA:16.0 Oct 10, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b5b7dfe. Thanks a lot for contributing to OCA. ❤️

@rousseldenis rousseldenis mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilshamerlinck nilshamerlinck nilshamerlinck left review comments

@simahawk simahawk simahawk approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

@cyrilmanuel cyrilmanuel cyrilmanuel approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.