Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][mig] stock_picking_product_assortment: Migration to 16.0 #1311

Merged
merged 10 commits into from
Jan 30, 2025
Merged

[16.0][mig] stock_picking_product_assortment: Migration to 16.0 #1311

merged 10 commits into from
Jan 30, 2025

Conversation

dsolanki-initos
Copy link
Contributor

No description provided.

@rousseldenis
Copy link
Contributor

/ocabot migration stock_picking_product_assortment

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 8, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 8, 2023
Open
71 tasks
AungKoKoLin1997
AungKoKoLin1997 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 9, 2024
@github-actions github-actions bot closed this Jul 14, 2024
@bosd
Copy link
Contributor

bosd commented Jan 18, 2025

@rousseldenis Can you please reopen and force push?

@rousseldenis rousseldenis reopened this Jan 20, 2025
@bosd
Copy link
Contributor

bosd commented Jan 20, 2025

Thanks! For some reason there is no runboat created for easy testing. 😢

@rousseldenis
Copy link
Contributor

Thanks! For some reason there is no runboat created for easy testing. 😢

I think you should rebase (no right to do it)

@bosd
Copy link
Contributor

bosd commented Jan 20, 2025

Ooh, I was hoping @OCA-git-bot was listening to you.

Anyway I run into this issue quite a bit.
Is there an easy way to get an overview who has the rights to command the ocabot and invoke merges?

@rousseldenis
Copy link
Contributor

Ooh, I was hoping @OCA-git-bot was listening to you.

In fact, nobody has that right. Rebase requires a push on user's branch. This is not authorized on company account(here initOS), only on individual accounts.

@bosd
Copy link
Contributor

bosd commented Jan 21, 2025

@dsolanki-initos Can you please rebase?
cc: @fkantelberg

@fkantelberg fkantelberg force-pushed the 16.0-mig-stock_picking_product_assortment branch from 27a9b5b to c5f4194 Compare January 23, 2025 13:59
@fkantelberg
Copy link
Member

I rebased it as requested.

bosd
bosd suggested changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review failed.
I'm able to select all products on the picking, instead of only the ones defined on the assortment.

Compared it against the V15 runboat. That one was working.

image

@fkantelberg
Copy link
Member

There are some commits from sep 2023 in the 15.0 branch (some refactoring based on base_view_inheritance_extension) which aren't in this branch but technically it seems to work. If I select the Azure Interior as partner I can only select FURN_9001. If I select a different partner I can select all products.

@bosd
Copy link
Contributor

bosd commented Jan 24, 2025

Ooh wierd that it is working for you, maybe our workflow is different. I will create a screencast later.

@bosd
Copy link
Contributor

bosd commented Jan 25, 2025

@fkantelberg

Stockpicking_product_assortment_test_video.-.Jan.25.2025.mp4

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 26, 2025
@fkantelberg
Copy link
Member

I see the difference. In this PR there is a limitation for outgoing pickings. In the 15.0 (especially in 8ae029a) this was dropped.

I cherry-picked the missing change and will have to test it

@rousseldenis
Copy link
Contributor

@fkantelberg @dsolanki-initos Could you check tests?

@fkantelberg fkantelberg force-pushed the 16.0-mig-stock_picking_product_assortment branch from 27db6e0 to 5b0a397 Compare January 27, 2025 08:20
@sergio-teruel @fkantelberg
[IMP] stock_picking_product_assortment: use base_view_inheritance_ext…
0400b64 
…ension module to extend product domain. Unnecessary code removed
@fkantelberg fkantelberg force-pushed the 16.0-mig-stock_picking_product_assortment branch from 5b0a397 to 0400b64 Compare January 27, 2025 08:30
@fkantelberg
Copy link
Member

@bosd My last cherry-pick fixed the different behaviour. Please test again :)

@bosd
Copy link
Contributor

bosd commented Jan 27, 2025

LGTM, Let's merge. ✨
I want this on V18, so will migrate it 😃

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@bosd
Copy link
Contributor

bosd commented Jan 28, 2025

@rousseldenis Can you please merge? 🙏

@bosd
Copy link
Contributor

bosd commented Jan 29, 2025

FYI V18 in #1858

@rousseldenis
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1311-by-rousseldenis-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 30, 2025
@OCA-git-bot
Merge PR #1311 into 16.0
e477d22 
Signed-off-by rousseldenis
@rousseldenis
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1311-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4447235 into OCA:16.0 Jan 30, 2025
12 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a4b8555. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosd bosd bosd approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@AungKoKoLin1997 AungKoKoLin1997 AungKoKoLin1997 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
8 participants
@dsolanki-initos @rousseldenis @bosd @fkantelberg @OCA-git-bot @AungKoKoLin1997 @CarlosRoca13 @sergio-teruel