[10.0][MIG] stock_cycle_count #332

LoisRForgeFlow · 2017-08-24T10:48:34Z

Migration from v9 to v10.

Depends on:

LoisRForgeFlow · 2017-08-24T10:58:59Z

@alan196 @rousseldenis you might be interested in this one

MiquelRForgeFlow · 2017-08-31T11:56:52Z

stock_cycle_count/models/stock_inventory.py

+                    PERCENT * (theoretical - abs_discrepancy) / theoretical,
+                    0.0)
+            if not inv.line_ids and inv.state == 'done':
+                inv.inventory_accuracy = 100.0


100.0 → PERCENT

Sure, thanks

rousseldenis

LGTM but there are IMHO lot of api issues

@lreficent Can you fix them ?

rousseldenis · 2017-10-02T09:45:15Z

stock_cycle_count/models/stock_cycle_count.py

+                                           inverse_name='cycle_count_id',
+                                           string='Inventory Adjustment',
+                                           track_visibility='onchange')
+    inventory_adj_count = fields.Integer(compute='_count_inventory_adj')


Following https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#models
the method name should be _compute...

rousseldenis · 2017-10-02T09:50:45Z

stock_cycle_count/models/stock_cycle_count.py

+    def do_cancel(self):
+        self.write({'state': 'cancelled'})
+
+    @api.model


@lreficent This one should have been decorated multi with ensure_one. Inconsistency between decorator and self value (not void recordset)

rousseldenis · 2017-10-02T09:51:43Z

stock_cycle_count/models/stock_cycle_count_rule.py

+    _name = 'stock.cycle.count.rule'
+    _description = "Stock Cycle Counts Rules"
+
+    @api.one


rousseldenis · 2017-10-02T09:52:03Z

stock_cycle_count/models/stock_cycle_count_rule.py

+            ('accuracy', _('Minimum Accuracy')),
+            ('zero', _('Zero Confirmation'))]
+
+    @api.one


rousseldenis · 2017-10-02T09:58:53Z

stock_cycle_count/models/stock_cycle_count_rule.py

+        else:
+            self.rule_description = _('(No description provided.)')
+
+    @api.constrains('periodic_qty_per_period', 'periodic_count_period')


@lreficent self can be a multi recordset

rousseldenis · 2017-10-02T10:15:25Z

stock_cycle_count/models/stock_location.py

+                if not quants:
+                    self.create_zero_confirmation_cycle_count()
+
+    def create_zero_confirmation_cycle_count(self):


@api.multi, self.ensure_one()

rousseldenis · 2017-10-02T10:16:14Z

stock_cycle_count/models/stock_warehouse.py

+        help='Number of latest inventories used to calculate location '
+             'accuracy')
+
+    @api.one


rousseldenis · 2017-10-02T10:16:59Z

stock_cycle_count/models/stock_warehouse.py

+            ('rule_type', '!=', 'zero'), ('warehouse_ids', '=', self.id)])
+        return rules
+
+    @api.one


rousseldenis · 2017-10-02T10:19:04Z

stock_cycle_count/models/stock_warehouse.py

+
+    @api.model
+    def _cycle_count_rules_to_compute(self):
+        rules = self.cycle_count_rule_ids.search([


To have more clearer code, could you use self.env[model].search() here ?

rousseldenis · 2017-10-02T10:20:00Z

stock_cycle_count/models/stock_warehouse.py

+    @api.model
+    def _cycle_count_rules_to_compute(self):
+        rules = self.cycle_count_rule_ids.search([
+            ('rule_type', '!=', 'zero'), ('warehouse_ids', '=', self.id)])


I think this works. But quite weird. I would have done ('warehouse_ids', 'in', [self.id])

LoisRForgeFlow · 2017-10-10T12:50:47Z

: Open improvements in v9: [9.0][IMP] stock_cycle_count: Add views and reports #346 EDIT: added

@rousseldenis yes, I have to clean all those api usages. I will do after the above improvements for v9 are merged

LoisRForgeFlow · 2018-01-03T11:11:16Z

@rousseldenis Finally I attended your review, Thanks!

gurneyalex · 2018-03-23T08:58:40Z

I triggered a runbot rebuild

rousseldenis

Some comments

rousseldenis · 2018-03-23T09:04:13Z

stock_cycle_count/models/stock_cycle_count.py

+        company_id = self.env['res.company']._company_default_get(self._name)
+        return company_id
+
+    name = fields.Char(string='Name', readonly=True)


Please follow OCA conventions and set fields definitions above.

rousseldenis · 2018-03-23T09:05:02Z

stock_cycle_count/models/stock_cycle_count.py

+    _description = "Stock Cycle Counts"
+    _inherit = 'mail.thread'
+
+    @api.multi


@api.depends('stock_adjustment_ids')

rousseldenis · 2018-03-23T09:08:07Z

stock_cycle_count/models/stock_cycle_count_rule.py

+                    )
+
+    @api.onchange('rule_type')
+    def _compute_rule_description(self):


Please follow OCA convention for onchange function name

it's both a compute method and an onchange method. https://github.com/Eficent/stock-logistics-warehouse/blob/b9b4c2283fdffebbcdb508e49e07a5e512d70cb6/stock_cycle_count/models/stock_cycle_count_rule.py#L100

If you put

@api.depends('rule_type')

The change on rule_type value will trigger the change on rule_description on the interface.

rousseldenis · 2018-03-23T09:08:47Z

stock_cycle_count/models/stock_cycle_count_rule.py

+                )
+
+    @api.onchange('location_ids')
+    def _get_warehouses(self):


Same as above.

rousseldenis · 2018-03-23T09:12:36Z

stock_cycle_count/models/stock_cycle_count_rule.py

+    def _compute_rule_periodic(self, locs):
+        cycle_counts = []
+        for loc in locs:
+            last_inventories = self.env['stock.inventory'].search([


Maybe the search can be directly order by date desc and limit=1 to fetch less records.

right, done.

rousseldenis · 2018-03-23T09:43:26Z

stock_cycle_count/models/stock_location.py

+    @api.multi
+    def _compute_loc_accuracy(self):
+        for rec in self:
+            history = self.env['stock.inventory'].search([


Maybe it could be interesting to have an inventory history field on locations ?

what kind of field, could you please explain a little bit more?

An 'inventory_history_ids' that represent inventories done on a location.

rousseldenis · 2018-03-23T09:46:23Z

stock_cycle_count/models/stock_move.py

+    def action_done(self):
+        super(StockMove, self).action_done()
+        for move in self:
+            move.location_id.check_zero_confirmation()


check_zero_confirmation() function is a real multi, maybe it could be called on all locations ?

rousseldenis · 2018-03-23T09:50:27Z

stock_cycle_count/models/stock_warehouse.py

+        return rules
+
+    @api.multi
+    def action_compute_cycle_count_rules(self):


IMHO, maybe this function could be refactorized as I see some searched records that can become fields(that could help reading - and some could be called on other code parts ?).

And the values set on the create at the end could be retrieved through a _prepare hook function.

agree, but I can't do that at the moment, I would look into it when I have some spare time :)

gurneyalex · 2018-03-23T09:56:28Z

runbot status unrelated. @lreficent if you rebase it should get green.

* Update README. * Fixes: DEFAULT_SERVER_DATETIME_FORMAT, PERCENT variables and sale price calculation.

… specific zones.

…manual creation of cycle counts.

…racking to some of them.

…tment related to a cycle count cannot be modified.

… cancel them.

… at a time

* simplify fetching latest inventory date * use api.depends where needed * add hook for cycle count creation * take advantage of api.multi on check_zero_confirmation method

rousseldenis

Code review.

Should add Roadmap for further version to improve the action_compute_cycle_count_rules in stock.warehouse

LoisRForgeFlow · 2018-03-27T15:01:21Z

@rousseldenis would you do the honors of merging this? 😉

rousseldenis · 2018-03-27T15:09:03Z

@lreficent Wait for all green checks, but yes of course!

[10.0] port stock_auto_move to 10.0

LoisRForgeFlow force-pushed the 10.0-mig-stock_cycle_count branch from d055950 to 8ba2f63 Compare August 24, 2017 10:50

MiquelRForgeFlow reviewed Aug 31, 2017

View reviewed changes

LoisRForgeFlow force-pushed the 10.0-mig-stock_cycle_count branch from c4fa7c0 to 7497965 Compare September 8, 2017 12:14

rousseldenis requested changes Oct 2, 2017

View reviewed changes

LoisRForgeFlow force-pushed the 10.0-mig-stock_cycle_count branch from 01e8395 to a4d958c Compare October 10, 2017 12:48

LoisRForgeFlow added the work in progress label Oct 18, 2017

LoisRForgeFlow added this to the 10.0 milestone Oct 18, 2017

LoisRForgeFlow force-pushed the 10.0-mig-stock_cycle_count branch 3 times, most recently from 6380d48 to 2c9cc48 Compare January 3, 2018 11:09

LoisRForgeFlow added needs review and removed work in progress labels Jan 3, 2018

LoisRForgeFlow force-pushed the 10.0-mig-stock_cycle_count branch from 30b87fa to 0d41688 Compare January 3, 2018 15:16

gurneyalex approved these changes Mar 23, 2018

View reviewed changes

rousseldenis requested changes Mar 23, 2018

View reviewed changes

LoisRForgeFlow force-pushed the 10.0-mig-stock_cycle_count branch 2 times, most recently from 120bf42 to 8c13a56 Compare March 23, 2018 15:31

LoisRForgeFlow and others added 8 commits March 26, 2018 10:26

[ADD] stock_cycle_count

dee9818

[ADD] Adding tests

734e901

[IMP] stock_cycle_count:

0c2505e

* Update README. * Fixes: DEFAULT_SERVER_DATETIME_FORMAT, PERCENT variables and sale price calculation.

[IMP] tests.

01d2bc9

[9.0][FIX] Solves issue when doing picking with several moves.

61c5aac

OCA Transbot updated translations from Transifex

4d5b5de

[9.0][IMP] stock_cycle_count: add the possibility to define rules for…

8e46bc5

… specific zones.

[9.0][FIX] stock_cycle_count: Do not propose cycle counts in the past.

364404f

LoisRForgeFlow and others added 16 commits March 26, 2018 10:26

[9.0][FIX] stock_cycle_count: Fix a bug when combining automatic and …

8ff1857

…manual creation of cycle counts.

[9.0][FIX] stock_cycle_count: fields only editable in draft and add t…

8352a3c

…racking to some of them.

[9.0][IMP] stock_cycle_count: Enhance tree view with filter and colors.

dfdebba

[9.0][IMP] stock_cycle_count: The configuration of an inventory adjus…

a9f30e1

…tment related to a cycle count cannot be modified.

[9.0][IMP] stock_cycle_count: update existing cycle counts instead of…

441cf63

… cancel them.

[9.0][IMP] stock_cycle_count: add server action to confirm several CC…

4b154ae

… at a time

OCA Transbot updated translations from Transifex

3b64497

[FIX] stock_cycle_count (usage cannot be 'view')

1bf659c

OCA Transbot updated translations from Transifex

6f24b49

[9.0][IMP] stock_cycle_count: fix accuracy computation and store it

23b8738

[9.0][IMP] stock_cycle_count: basic_accuracy report

8f01c9a

[9.0][IMP] stock_cycle_count: enhance views

f6256d3

[9.0][IMP] stock_cycle_count: cycle counts report

6712f2a

OCA Transbot updated translations from Transifex

d1d8a26

[10.0][MIG] stock_cycle_count

c604fa1

cycle_count: fix cycle count state issue

56a937e

LoisRForgeFlow force-pushed the 10.0-mig-stock_cycle_count branch 2 times, most recently from a6556c8 to 0fe8761 Compare March 26, 2018 08:30

LoisRForgeFlow added 3 commits March 26, 2018 10:31

[10.0][IMP] fix api issues and clean up code

c5fd741

[10.0] stock_cycle_count: adapt to follow OCA convention.

1062159

[10.0][IMP] stock_cycle_count:

d5a9498

* simplify fetching latest inventory date * use api.depends where needed * add hook for cycle count creation * take advantage of api.multi on check_zero_confirmation method

LoisRForgeFlow force-pushed the 10.0-mig-stock_cycle_count branch from 0fe8761 to d5a9498 Compare March 26, 2018 08:31

rousseldenis approved these changes Mar 26, 2018

View reviewed changes

[10.0][UPD] stock_cycle_count: add roadmap.

e1c95de

rousseldenis merged commit a93993d into OCA:10.0 Mar 27, 2018

MiquelRForgeFlow deleted the 10.0-mig-stock_cycle_count branch March 27, 2018 15:33

LRovira-PlanetaTIC pushed a commit to PlanetaTIC/stock-logistics-warehouse that referenced this pull request May 15, 2020

Merge pull request OCA#332 from acsone/10.0-stock_auto_move-cpi

f30c031

[10.0] port stock_auto_move to 10.0

[10.0][MIG] stock_cycle_count #332

[10.0][MIG] stock_cycle_count #332

Conversation

LoisRForgeFlow commented Aug 24, 2017 • edited Loading

LoisRForgeFlow commented Aug 24, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rousseldenis left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LoisRForgeFlow commented Oct 10, 2017 • edited Loading

LoisRForgeFlow commented Jan 3, 2018

gurneyalex commented Mar 23, 2018

rousseldenis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gurneyalex commented Mar 23, 2018

rousseldenis left a comment

Choose a reason for hiding this comment

LoisRForgeFlow commented Mar 27, 2018

rousseldenis commented Mar 27, 2018

LoisRForgeFlow commented Aug 24, 2017 •

edited

Loading

rousseldenis left a comment •

edited

Loading

LoisRForgeFlow commented Oct 10, 2017 •

edited

Loading