[17.0][MIG] stock_picking_report_custom_description: Migration to 17.0 #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* README by fragments * Remove models * Fix report templates [UPD] Update stock_picking_report_custom_description.pot [UPD] README.rst
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_custom_description Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_custom_description/
Currently translated at 100.0% (2 of 2 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_custom_description Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_custom_description/es/
Currently translated at 100.0% (2 of 2 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_picking_report_custom_description Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_picking_report_custom_description/it/
By default the sale description is set as
f"{product_name}\n{description". If we pass that string as the
description_picking, when we print the report, the name will be
duplicated. To avoid that effect, we want to trim the product name from
the description passed to the picking by default.
TT52044
It isn't very common to write the name in batch. Anyway it would lead to errors in it's current shape. TT52171
i've seen it before, but its been a long time without a response, and the pr is outdated, i thought it was appropriate to open a new pr, or am i missing something? |
Ok, then. You can comment it in the top comment |
chienandalu
approved these changes
Jan 9, 2025
|
/ocabot migration stock_picking_report_custom_description |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 0b854eb. Thanks a lot for contributing to OCA. ❤️ |
nico-foodles
pushed a commit
to nico-foodles/stock-logistics-reporting
that referenced
this pull request
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to 17.0
This pr is intended to replace #311 which has been inactive.
@Tecnativa TT52374
@pilarvargas-tecnativa @chienandalu Could you please review? Thx!