[15.0][IMP] stock_picking_report_custom_description: update description #358
+33
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @carlosdauden, |
rousseldenis
requested changes
Dec 12, 2024
| def write(self, vals): | ||
| res = super().write(vals) | ||
| if vals.get("name"): | ||
| self.env["stock.move"].search([("sale_line_id", "=", self.id)]).name = vals[ |
There was a problem hiding this comment.
This is not correct.
Suggested change
| self.env["stock.move"].search([("sale_line_id", "=", self.id)]).name = vals[ | |
| self.env["stock.move"].search([("sale_line_id", "in", self.ids)]).update({"name": vals["name"]}) |
There was a problem hiding this comment.
OK about the in operator, but you don't need update, as dot notation serves also for writing in a multi-record.
There was a problem hiding this comment.
Thanks @rousseldenis :). I just changed. As @pedrobaeza said, we don't need the update anyway. I'll check v16, as this is a potential bug.
Before this change only when the procurements where updated the sale line description would be propagated so if a user updated that description after the sale was confirmed it wouldn't be written to the picking move. Now every time the user changes the line it will be synced to the related moves. TT52171
chienandalu
force-pushed
the
15.0-imp-stock_picking_report_custom_description-desc-update
branch
from
1423f4d to
69c403f
Compare
pedrobaeza
reviewed
Dec 12, 2024
carlosdauden
approved these changes
Dec 12, 2024
pedrobaeza
approved these changes
Dec 12, 2024
rousseldenis
approved these changes
Dec 12, 2024
|
/ocabot merge minor |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 609fa24. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
15.0-imp-stock_picking_report_custom_description-desc-update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially backported from the v16 feature
Before this change only when the procurements where updated the sale line description would be propagated so if a user updated that description after the sale was confirmed it wouldn't be written to the picking move.
Now every time the user changes the line it will be synced to the related moves.
cc @Tecnativa TT52171
please review @pilarvargas-tecnativa @carlos-lopez-tecnativa