Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] auto_printing_stock_picking #354

Open
wants to merge 4 commits into
base: 14.0
Choose a base branch
from

Conversation

jbaudoux
Copy link
Contributor

@jbaudoux jbaudoux commented Dec 6, 2024

When a picking is done, automatically trigger the printing of some documents.
This can be used to print a delivery slip (report) or labels received from the carrier (attachment).

Depends on:

@jbaudoux jbaudoux force-pushed the 14-auto_printing_stock_picking branch 2 times, most recently from 2503698 to 42a1035 Compare December 6, 2024 12:35
@rousseldenis rousseldenis added this to the 14.0 milestone Dec 6, 2024
@jbaudoux jbaudoux force-pushed the 14-auto_printing_stock_picking branch from 42a1035 to 15c1705 Compare December 6, 2024 13:31
@jbaudoux
Copy link
Contributor Author

jbaudoux commented Dec 6, 2024

cc @mt-software-de @sebalix

Copy link

@mt-software-de mt-software-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@jbaudoux jbaudoux force-pushed the 14-auto_printing_stock_picking branch from 15c1705 to 42d6eb0 Compare January 22, 2025 13:50
auto_printing_ids = fields.Many2many(
"printing.auto",
string="Auto Printing Configuration",
domain=[("model", "=", "stock.picking.type")],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mt-software-de I wonder if this is not a mistake and if we should not put the model of what is printed instead of where it is configured? And in _get_printing_auto filter on that model. https://github.com/OCA/report-print-send/pull/310/files#diff-1360f4baf5029947c074c2576244e65952f4043906416d240f5026996ac26f68R37

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I don't quite understand what you mean.
We need to configure the printing.auto on the picking.type.
I also think we should change the model in the domain to stock.picking. This then aligned with the model which is printing.
But a filter is not needed, because the auto_printing_ids are on the model with the mixin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants