[16.0][FIX] stock_picking_report_custom_description: avoid dupe product name #353
Conversation
|
Hi @carlosdauden, |
| @@ -31,6 +31,14 @@ def _get_stock_move_values( | |||
| ) | |||
| if values.get("sale_line_id"): | |||
| line = self.env["sale.order.line"].browse(values["sale_line_id"]) | |||
| res["description_picking"] = line.name | |||
| # Avoid printing double printing the name in the picking | |||
There was a problem hiding this comment.
| # Avoid printing double printing the name in the picking | |
| # Avoid double printing the name in the picking |
| @@ -31,6 +31,14 @@ def _get_stock_move_values( | |||
| ) | |||
| if values.get("sale_line_id"): | |||
| line = self.env["sale.order.line"].browse(values["sale_line_id"]) | |||
| res["description_picking"] = line.name | |||
| # Avoid printing double printing the name in the picking | |||
| description_picking = line.name.replace( | |||
There was a problem hiding this comment.
Replacing unconditionally whole display_name seems too much, isn't it? Shouldn't it be only removed in case of having something more?
if line != line.product_id.display_name:There was a problem hiding this comment.
It's what I do in the line below. And I only replace it in case of matching the pattern f"{product.display_name}\n", not just the display name. That pattern comes from the method get_product_multiline_description_sale`. It basically goes like this:
name = self.display_name
if self.description_sale:
name += '\n' + self.description_saleSo I just want to look after that issue.
There was a problem hiding this comment.
Well, not exactly, as you are doing an unconditional replace in any part of the text. Imagine a product called Test and this SOL line text:
Test
This is a Test
Another line
you will end up with
This is a Another Line
There was a problem hiding this comment.
Ok, I can improve it with a regex match 😅
There was a problem hiding this comment.
Or simply an startswith plus a replace with just 1 repetition.
There was a problem hiding this comment.
I don't know if my suggestion is faster, but usually everything is faster than regex.
chienandalu
force-pushed
the
16.0-fix-stock-logistics-reporting-avoid-duplicating-name
branch
from
3112e1d to
2802e89
Compare
By default the sale description is set as
f"{product_name}\n{description". If we pass that string as the
description_picking, when we print the report, the name will be
duplicated. To avoid that effect, we want to trim the product name from
the description passed to the picking by default.
TT52044
|
@pedrobaeza Changes done |
chienandalu
force-pushed
the
16.0-fix-stock-logistics-reporting-avoid-duplicating-name
branch
from
2802e89 to
62a9f6b
Compare
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at ca4c165. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
16.0-fix-stock-logistics-reporting-avoid-duplicating-name
branch
By default the sale description is set as
f"{product_name}\n{description". If we pass that string as the description_picking, when we print the report, the name will be duplicated. To avoid that effect, we want to trim the product name from the description passed to the picking by default.
cc @Tecnativa TT52044
please review @pedrobaeza @pilarvargas-tecnativa