Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] stock_account_valuation_report: improve searching on discrepancies #338

Merged

Conversation

AaronHForgeFlow
Copy link
Contributor

Otherwise we can get False positive results when applying the filters:

2024-09-13_15-09

cc@ForgeFlow

@AaronHForgeFlow AaronHForgeFlow force-pushed the 16.0-fix-stock_account_valuation_report-search branch from e356599 to 3e0bcbb Compare September 13, 2024 13:39
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from comment made by Miquel, LGTM

@AaronHForgeFlow AaronHForgeFlow force-pushed the 16.0-fix-stock_account_valuation_report-search branch from f717767 to 939f7f0 Compare November 11, 2024 11:48
… filtering products with discrepancies

also add a filter to see all discrepancies at once
@AaronHForgeFlow AaronHForgeFlow force-pushed the 16.0-fix-stock_account_valuation_report-search branch from 939f7f0 to d0c56d2 Compare November 11, 2024 13:47
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-338-by-LoisRForgeFlow-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4f397ed into OCA:16.0 Nov 29, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4cd924f. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 16.0-fix-stock_account_valuation_report-search branch November 29, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants