Skip to content

[ADD][16.0] base_user_group_mgmt: manage groups/roles assignation with validation #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 16.0
Choose a base branch
from

Conversation

benwillig
Copy link
Contributor

This PR creates two modules which allow users to assign group and roles to a user only if a workflow is approved.

  • base_user_group_mgmt: add/remove groups from users, add/remove groups from groups
  • base_user_group_mgmt_role: add/remove users from roles, add/removes groups from roles

Related fields are set readonly (only in the UI)

Copy link

@sbejaoui sbejaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Code review

@@ -0,0 +1,7 @@
[ This file is optional and contains additional credits, other than

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unused README fragment

Comment on lines 71 to 90
<!-- <record-->
<!-- model="ir.actions.act_window"-->
<!-- id="base_security_update_request_request_line_act_window"-->
<!-- >-->
<!-- <field name="name">Base Security Update Line</field> &lt;!&ndash; TODO &ndash;&gt;-->
<!-- <field name="res_model">base.security.update.request.line</field>-->
<!-- <field name="view_mode">tree,form</field>-->
<!-- <field name="domain">[]</field>-->
<!-- <field name="context">{}</field>-->
<!-- </record>-->

<!-- <record model="ir.ui.menu" id="base_security_update_request_request_line_menu">-->
<!-- <field name="name">Base Security Update Line</field>-->
<!-- <field name="parent_id" ref="xmlid of parent menu" /> &lt;!&ndash; TODO &ndash;&gt;-->
<!-- <field-->
<!-- name="action"-->
<!-- ref="base_security_update_request_request_line_act_window"-->
<!-- />-->
<!-- <field name="sequence" eval="16" /> &lt;!&ndash; TODO &ndash;&gt;-->
<!-- </record>-->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- <record-->
<!-- model="ir.actions.act_window"-->
<!-- id="base_security_update_request_request_line_act_window"-->
<!-- >-->
<!-- <field name="name">Base Security Update Line</field> &lt;!&ndash; TODO &ndash;&gt;-->
<!-- <field name="res_model">base.security.update.request.line</field>-->
<!-- <field name="view_mode">tree,form</field>-->
<!-- <field name="domain">[]</field>-->
<!-- <field name="context">{}</field>-->
<!-- </record>-->
<!-- <record model="ir.ui.menu" id="base_security_update_request_request_line_menu">-->
<!-- <field name="name">Base Security Update Line</field>-->
<!-- <field name="parent_id" ref="xmlid of parent menu" /> &lt;!&ndash; TODO &ndash;&gt;-->
<!-- <field-->
<!-- name="action"-->
<!-- ref="base_security_update_request_request_line_act_window"-->
<!-- />-->
<!-- <field name="sequence" eval="16" /> &lt;!&ndash; TODO &ndash;&gt;-->
<!-- </record>-->

@benwillig benwillig force-pushed the 16.0-add_base_security_management-bwi branch from db14779 to 4954191 Compare April 15, 2025 11:39
@benwillig benwillig force-pushed the 16.0-add_base_security_management-bwi branch from 4954191 to 5bfe932 Compare April 16, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants