Skip to content

[18.0][MIG] base_global_discount: Migration to 18.0 #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
May 27, 2025
Merged

[18.0][MIG] base_global_discount: Migration to 18.0 #342

merged 19 commits into from
May 27, 2025

Conversation

eugenios73
Copy link

Migration base_global_discount from 17.0 to 18.0

@mcodes-o mcodes-o mentioned this pull request Mar 1, 2025
Closed
@eugenios73
Copy link
Author

eugenios73 commented Apr 16, 2025 •
edited
Loading

@BhaveshHeliconia, @pedrobaeza , @mcodes-o
Anyone can you review PR, please?

@eugenios73 eugenios73 changed the title [MIG] base_global_discount: Migration to 18.0 [18.0][MIG] base_global_discount: Migration to 18.0 Apr 29, 2025
@mcodes-o
Copy link

Can you squash the CI and weblate commits? Like these:

image

See the guide https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate on how to do this

David and others added 19 commits May 19, 2025 11:31
@eugenios73
[ADD] base_global_discount: New Module 11.0
b9e22b0
@manuelcalerosolis @eugenios73
[MIG] base_global_discount: Migration to 12.0
c1f9fdd
@pedrocs-exo @eugenios73
Added translation using Weblate (Portuguese)
cecf292
@eugenios73
[IMP] base_global_discount: black, isort, prettier
8db56fa
@eugenios73
[MIG] base_global_discount: Migration to 13.0
a5cadcf 
[UPD] Update base_global_discount.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-backend-13.0/server-backend-13.0-base_global_discount
Translate-URL: https://translation.odoo-community.org/projects/server-backend-13-0/server-backend-13-0-base_global_discount/
@eugenios73
Added translation using Weblate (Dutch)
083defe
@eugenios73
[IMP] base_global_discount: add specific security group
cac07b4 
This way, it will be easier to decide who can set discount or not. The
current group scope is too broad.

[UPD] Update base_global_discount.pot
@OCA-git-bot @eugenios73
base_global_discount 13.0.2.0.0
0dcc146 
Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-backend-13.0/server-backend-13.0-base_global_discount
Translate-URL: https://translation.odoo-community.org/projects/server-backend-13-0/server-backend-13-0-base_global_discount/
@omar7r @eugenios73
[MIG] base_global_discount: Migration to 14.0
1ca28e7
@kirca @eugenios73
[MIG] base_global_discount: Migration to 15.0
0f2ca36
@ferran-S73 @eugenios73
[MIG] base_global_discount: 16.0
38eee01
@Ivorra78 @eugenios73
Translated using Weblate (Spanish)
d750ee5 
Currently translated at 100.0% (21 of 21 strings)

Translation: server-backend-16.0/server-backend-16.0-base_global_discount
Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_global_discount/es/
@OCA-git-bot @eugenios73
[UPD] README.rst
0890be0
@mymage @eugenios73
Added translation using Weblate (Italian)
c982090
@ferran-S73 @eugenios73
[16.0][IMP] base_global_discount: Add flag in product to bypass discount
684a42d
@mymage @eugenios73
Translated using Weblate (Italian)
57f90ad 
Currently translated at 100.0% (25 of 25 strings)

Translation: server-backend-16.0/server-backend-16.0-base_global_discount
Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_global_discount/it/
@miguel-S73 @eugenios73
[IMP] base_global_discount: pre-commit auto fixes
29e170e
@miguel-S73 @eugenios73
[MIG] base_global_discount: Migration to 17.0
c3408c6
@eugenios73
[MIG] base_global_discount: Migration to 18.0
f8d5511
@eugenios73 eugenios73 force-pushed the 18.0-mig-base_global_discount branch from 66761d9 to f8d5511 Compare May 19, 2025 09:36
@eugenios73
Copy link
Author

Hi @mcodes-o , thanks for you review.

I've squashed the commits. Could you please review them and check if everything looks good?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link

/ocabot migration base_global_discount

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone May 27, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request May 27, 2025
Open
6 tasks
@rousseldenis
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-342-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 30506cd into OCA:18.0 May 27, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f5d5e55. Thanks a lot for contributing to OCA. ❤️

This was referenced May 27, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@miguel-S73 miguel-S73 miguel-S73 approved these changes

@mcodes-o mcodes-o mcodes-o approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.