[18.0][MIG] base_user_role_history: Migration to 18.0. #338
Conversation
|
@ThomasBinsfeld Since you're listed as a maintainer, do you have time to look at this PR? Thanks! |
|
This PR has the |
| self.ensure_one() | ||
| domain = [("user_id", "=", self.id)] | ||
| return { | ||
| "name": _("Roles history"), |
There was a problem hiding this comment.
You can replace the call to translate a string ( _ ) with self.env._ for getting some performance improvement in some cases. See odoo/odoo#174844.
There was a problem hiding this comment.
Can you squash this together with the "Migration to 18.0" commit?
There was a problem hiding this comment.
LGTM, but some small findings:
Squash administrative commits (if any) with the previous commit for reducing commit noise. Check https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate for details.
Currently translated at 100.0% (28 of 28 strings) Translation: server-backend-17.0/server-backend-17.0-base_user_role_history Translate-URL: https://translation.odoo-community.org/projects/server-backend-17-0/server-backend-17-0-base_user_role_history/it/
mcodes-o
force-pushed
the
18.0-mig-base_user_role_history
branch
from
3ac3b98 to
f59c810
Compare
@CRogos I've squashed the commits and pushed. Thanks for the review! |
|
@mcodes-o these need to be squashed too: |
|
|
||
|
|
||
| # DEPRECATED: This tests are deprecated but stay to show that the new code is working. | ||
| class TestBaseUserRoleHistory(TransactionCase): |
There was a problem hiding this comment.
Use BaseCommon as base test class to reduce overhead from tracking and boost the test suite.
Maybe also check if the depricated tests can be removed?
|
@mcodes-o are you still working on this? |
Migrated to 18.0