Skip to content

[18.0][ADD] auth_oauth_login_field #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sbidoul wants to merge 2 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][ADD] auth_oauth_login_field #845

sbidoul wants to merge 2 commits into from

Conversation

@sbidoul
Copy link
Member

@sbidoul sbidoul commented Oct 9, 2025

Handle the login field from the JWT token in OAuth signup.

This is useful when you need to create users where the login field is different from the email field.

@sbidoul sbidoul force-pushed the 18.0-auth_oidc-login-field branch from af7f7f6 to a70c858 Compare October 9, 2025 08:11
@sbidoul sbidoul changed the title [ADD] auth_oauth_login_field [18.0][ADD] auth_oauth_login_field Oct 9, 2025
@sbidoul sbidoul added this to the 18.0 milestone Oct 9, 2025
baimont
baimont approved these changes Oct 9, 2025
View reviewed changes
Copy link

@baimont baimont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review

qgroulard
qgroulard approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@qgroulard qgroulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review)

@sbidoul sbidoul force-pushed the 18.0-auth_oidc-login-field branch from a70c858 to 8fa3952 Compare October 9, 2025 11:15
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Oct 14, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@baimont baimont baimont approved these changes

@qgroulard qgroulard qgroulard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

4 participants

@sbidoul @OCA-git-bot @baimont @qgroulard