-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] auth_admin_passkey: Migration to 18.0 #740
Conversation
…o login with any login and his password.
…ion if user_id == SUPERUSER_ID. (Courtesy of Stefan Rijnhart).
…s the same password as the admin user, sending a mail to admin user.
… installation of modules 'auth_admin_passkey' and 'auth_crypt'. (Courtesy of Stefan Rijnhart).
…xxx'] [REF] res_users.py : same call to self.pool in other res_users class.
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
Currently translated at 100.0% (3 of 3 strings) Translation: server-auth-17.0/server-auth-17.0-auth_admin_passkey Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-auth_admin_passkey/it/
In the res_users.py file, the `ignore_totp` session variable is now set based on the value of the `auth_admin_passkey_ignore_totp` configuration option. If the option is enabled, the `ignore_totp` session variable is set to True. This ensures that the `_mfa_url` method returns None when `ignore_totp` is True, effectively bypassing the 2FA check.
37f98fc
to
fda78d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the code coverage errors, for the reset, the code looks good.
fda78d0
to
fccb724
Compare
fccb724
to
0772cac
Compare
Added more tests, now all checks have passed. |
@OCA/tools-maintainers Hello :) can somebody do a review for me? |
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
/ocabot migration auth_admin_passkey |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 1d1ad6b. Thanks a lot for contributing to OCA. ❤️ |
No description provided.